From: Kelsey Skunberg <skunberg.kelsey@gmail.com>
To: Stanislav Fomichev <sdf@fomichev.me>
Cc: shuah@kernel.org, ast@kernel.org, daniel@iogearbox.net,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] selftests: bpf: Add files generated when compiled to .gitignore
Date: Sun, 12 May 2019 01:34:29 -0600 [thread overview]
Message-ID: <20190512073427.GA10811@asus> (raw)
In-Reply-To: <20190512062907.GL1247@mini-arch>
On Sat, May 11, 2019 at 11:29:07PM -0700, Stanislav Fomichev wrote:
> On 05/11, Kelsey Skunberg wrote:
> > The following files are generated when /selftests/bpf/ is compiled and
> > should be added to .gitignore:
> >
> > - libbpf.pc
> > - libbpf.so.0
> > - libbpf.so.0.0.3
> >
> > Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
> > ---
> > tools/testing/selftests/bpf/.gitignore | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
> > index 41e8a689aa77..ceb11f98fe4f 100644
> > --- a/tools/testing/selftests/bpf/.gitignore
> > +++ b/tools/testing/selftests/bpf/.gitignore
> > @@ -32,3 +32,6 @@ test_tcpnotify_user
> > test_libbpf
> > test_tcp_check_syncookie_user
> > alu32
> > +libbpf.pc
>
> [..]
> > +libbpf.so.0
> > +libbpf.so.0.0.3
> How about libbpf.so.* so we don't have to update it on every release?
>
That seems logical. Updated in v2. I appreciate the feedback!
Cheers,
Kelsey
> > --
> > 2.20.1
> >
prev parent reply other threads:[~2019-05-12 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 3:50 [PATCH] selftests: bpf: Add files generated when compiled to .gitignore Kelsey Skunberg
2019-05-12 6:29 ` Stanislav Fomichev
2019-05-12 7:34 ` Kelsey Skunberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190512073427.GA10811@asus \
--to=skunberg.kelsey@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).