From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jagdish Motwani <Jagdish.Motwani@Sophos.com>
Cc: Jagdish Motwani <j.k.motwani@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"coreteam@netfilter.org" <coreteam@netfilter.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] netfilter: nf_queue:fix reinject verdict handling
Date: Mon, 13 May 2019 12:40:31 +0200 [thread overview]
Message-ID: <20190513104031.np2ollc6njuof2s2@salvia> (raw)
In-Reply-To: <CWXP265MB1464BCF96C61A8FD47619AE59E0F0@CWXP265MB1464.GBRP265.PROD.OUTLOOK.COM>
On Mon, May 13, 2019 at 10:36:51AM +0000, Jagdish Motwani wrote:
> Hi Pablo,
>
> The case I am referring to is : If there are more than 1 hooks
> returning NF_QUEUE verdict. When the first queue reinjects the
> packet, 'nf_reinject' starts traversing hooks with hook_index (i).
> However if it again receives a NF_QUEUE verdict (by some other
> netfilter hook), it queue with the wrong hook_index. So, when the
> second queue reinjects the packet, it re-executes some hooks in
> between the first 2 hooks.
Please, include this description in the patch. And thanks for
explaining.
> Thanks, I will mark : Fixes: 960632ece694 ("netfilter: convert hook list to an array") and update the description also.
Thanks, will wait for v2.
prev parent reply other threads:[~2019-05-13 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 18:31 [PATCH net] netfilter: nf_queue:fix reinject verdict handling Jagdish Motwani
2019-05-13 9:22 ` Pablo Neira Ayuso
2019-05-13 10:36 ` Jagdish Motwani
2019-05-13 10:40 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513104031.np2ollc6njuof2s2@salvia \
--to=pablo@netfilter.org \
--cc=Jagdish.Motwani@Sophos.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=j.k.motwani@gmail.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox