From: Andrew Lunn <andrew@lunn.ch>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: netdev@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: macb: fix error format in dev_err()
Date: Tue, 14 May 2019 14:35:10 +0200 [thread overview]
Message-ID: <20190514123510.GA5892@lunn.ch> (raw)
In-Reply-To: <20190514071450.27760-1-luca@lucaceresoli.net>
On Tue, May 14, 2019 at 09:14:50AM +0200, Luca Ceresoli wrote:
> Errors are negative numbers. Using %u shows them as very large positive
> numbers such as 4294967277 that don't make sense. Use the %d format
> instead, and get a much nicer -19.
Hi Luca
Do you consider this a fix? If so, it should be against David net
tree, and have [PATCH net] in the subject. It would also be good to
add a Fixes: tag.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-05-14 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 7:14 [PATCH] net: macb: fix error format in dev_err() Luca Ceresoli
2019-05-14 7:24 ` Nicolas.Ferre
2019-05-14 12:35 ` Andrew Lunn [this message]
2019-05-14 13:25 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514123510.GA5892@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).