* [PATCH] net: macb: fix error format in dev_err()
@ 2019-05-14 7:14 Luca Ceresoli
2019-05-14 7:24 ` Nicolas.Ferre
2019-05-14 12:35 ` Andrew Lunn
0 siblings, 2 replies; 4+ messages in thread
From: Luca Ceresoli @ 2019-05-14 7:14 UTC (permalink / raw)
To: netdev; +Cc: Luca Ceresoli, Nicolas Ferre, David S. Miller, linux-kernel
Errors are negative numbers. Using %u shows them as very large positive
numbers such as 4294967277 that don't make sense. Use the %d format
instead, and get a much nicer -19.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
drivers/net/ethernet/cadence/macb_main.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index c049410bc888..bebd9b1aeb64 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -3343,7 +3343,7 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
if (!err)
err = -ENODEV;
- dev_err(&pdev->dev, "failed to get macb_clk (%u)\n", err);
+ dev_err(&pdev->dev, "failed to get macb_clk (%d)\n", err);
return err;
}
@@ -3352,7 +3352,7 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
if (!err)
err = -ENODEV;
- dev_err(&pdev->dev, "failed to get hclk (%u)\n", err);
+ dev_err(&pdev->dev, "failed to get hclk (%d)\n", err);
return err;
}
@@ -3370,31 +3370,31 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
err = clk_prepare_enable(*pclk);
if (err) {
- dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);
+ dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);
return err;
}
err = clk_prepare_enable(*hclk);
if (err) {
- dev_err(&pdev->dev, "failed to enable hclk (%u)\n", err);
+ dev_err(&pdev->dev, "failed to enable hclk (%d)\n", err);
goto err_disable_pclk;
}
err = clk_prepare_enable(*tx_clk);
if (err) {
- dev_err(&pdev->dev, "failed to enable tx_clk (%u)\n", err);
+ dev_err(&pdev->dev, "failed to enable tx_clk (%d)\n", err);
goto err_disable_hclk;
}
err = clk_prepare_enable(*rx_clk);
if (err) {
- dev_err(&pdev->dev, "failed to enable rx_clk (%u)\n", err);
+ dev_err(&pdev->dev, "failed to enable rx_clk (%d)\n", err);
goto err_disable_txclk;
}
err = clk_prepare_enable(*tsu_clk);
if (err) {
- dev_err(&pdev->dev, "failed to enable tsu_clk (%u)\n", err);
+ dev_err(&pdev->dev, "failed to enable tsu_clk (%d)\n", err);
goto err_disable_rxclk;
}
@@ -3868,7 +3868,7 @@ static int at91ether_clk_init(struct platform_device *pdev, struct clk **pclk,
err = clk_prepare_enable(*pclk);
if (err) {
- dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);
+ dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);
return err;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: macb: fix error format in dev_err()
2019-05-14 7:14 [PATCH] net: macb: fix error format in dev_err() Luca Ceresoli
@ 2019-05-14 7:24 ` Nicolas.Ferre
2019-05-14 12:35 ` Andrew Lunn
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas.Ferre @ 2019-05-14 7:24 UTC (permalink / raw)
To: luca, netdev; +Cc: davem, linux-kernel, Claudiu.Beznea
On 14/05/2019 at 09:14, Luca Ceresoli wrote:
> External E-Mail
>
>
> Errors are negative numbers. Using %u shows them as very large positive
> numbers such as 4294967277 that don't make sense. Use the %d format
> instead, and get a much nicer -19.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Indeed!
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index c049410bc888..bebd9b1aeb64 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -3343,7 +3343,7 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
> if (!err)
> err = -ENODEV;
>
> - dev_err(&pdev->dev, "failed to get macb_clk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to get macb_clk (%d)\n", err);
> return err;
> }
>
> @@ -3352,7 +3352,7 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
> if (!err)
> err = -ENODEV;
>
> - dev_err(&pdev->dev, "failed to get hclk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to get hclk (%d)\n", err);
> return err;
> }
>
> @@ -3370,31 +3370,31 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
>
> err = clk_prepare_enable(*pclk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);
> return err;
> }
>
> err = clk_prepare_enable(*hclk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable hclk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable hclk (%d)\n", err);
> goto err_disable_pclk;
> }
>
> err = clk_prepare_enable(*tx_clk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable tx_clk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable tx_clk (%d)\n", err);
> goto err_disable_hclk;
> }
>
> err = clk_prepare_enable(*rx_clk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable rx_clk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable rx_clk (%d)\n", err);
> goto err_disable_txclk;
> }
>
> err = clk_prepare_enable(*tsu_clk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable tsu_clk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable tsu_clk (%d)\n", err);
> goto err_disable_rxclk;
> }
>
> @@ -3868,7 +3868,7 @@ static int at91ether_clk_init(struct platform_device *pdev, struct clk **pclk,
>
> err = clk_prepare_enable(*pclk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);
> return err;
> }
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: macb: fix error format in dev_err()
2019-05-14 7:14 [PATCH] net: macb: fix error format in dev_err() Luca Ceresoli
2019-05-14 7:24 ` Nicolas.Ferre
@ 2019-05-14 12:35 ` Andrew Lunn
2019-05-14 13:25 ` Luca Ceresoli
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Lunn @ 2019-05-14 12:35 UTC (permalink / raw)
To: Luca Ceresoli; +Cc: netdev, Nicolas Ferre, David S. Miller, linux-kernel
On Tue, May 14, 2019 at 09:14:50AM +0200, Luca Ceresoli wrote:
> Errors are negative numbers. Using %u shows them as very large positive
> numbers such as 4294967277 that don't make sense. Use the %d format
> instead, and get a much nicer -19.
Hi Luca
Do you consider this a fix? If so, it should be against David net
tree, and have [PATCH net] in the subject. It would also be good to
add a Fixes: tag.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: macb: fix error format in dev_err()
2019-05-14 12:35 ` Andrew Lunn
@ 2019-05-14 13:25 ` Luca Ceresoli
0 siblings, 0 replies; 4+ messages in thread
From: Luca Ceresoli @ 2019-05-14 13:25 UTC (permalink / raw)
To: Andrew Lunn; +Cc: netdev, Nicolas Ferre, David S. Miller, linux-kernel
Hi Andrew,
On 14/05/19 14:35, Andrew Lunn wrote:
> On Tue, May 14, 2019 at 09:14:50AM +0200, Luca Ceresoli wrote:
>> Errors are negative numbers. Using %u shows them as very large positive
>> numbers such as 4294967277 that don't make sense. Use the %d format
>> instead, and get a much nicer -19.
>
> Hi Luca
>
> Do you consider this a fix? If so, it should be against David net
> tree, and have [PATCH net] in the subject. It would also be good to
> add a Fixes: tag.
Thanks for the hint! I just resent with these changes.
You can ignore this patch.
--
Luca
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-14 13:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-14 7:14 [PATCH] net: macb: fix error format in dev_err() Luca Ceresoli
2019-05-14 7:24 ` Nicolas.Ferre
2019-05-14 12:35 ` Andrew Lunn
2019-05-14 13:25 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).