From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB70C04E53 for ; Wed, 15 May 2019 12:19:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 646C3206BF for ; Wed, 15 May 2019 12:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557922790; bh=7x3Adozaa64oTBpdwFSjRDCfOoqmldrh7ZB+3Q+gZuE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=I64mcSBakQlX49L57FUto5DXjcU6vcXbztml4PVa0Pufj/X0/ORiX2YqfrPlEp0X/ iqAT1M0p6NyvPD4SJT2jExRivGd+0NiJJ53v3X/X+Y3aUIByT1mI/JNRJXp2jitNpg YX6JzARcUfu4wJTlZTFNDqRhHN7UaHBV1ANxKfo8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727401AbfEOLAV (ORCPT ); Wed, 15 May 2019 07:00:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:57076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727376AbfEOLAR (ORCPT ); Wed, 15 May 2019 07:00:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 621B621734; Wed, 15 May 2019 11:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557918016; bh=7x3Adozaa64oTBpdwFSjRDCfOoqmldrh7ZB+3Q+gZuE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1qAf7G8+MNwcgWm+JIcL4QToH0AriFEJXWMCP9TfviQZkGf8/5qTeyOkL+U3ju775 Ube76QoOzIplhKyZ0SUIxphBmKJd8FJnWxHRTaZnbgPziz7M480BBplC3k/2wP8iAv M2q37v2qzH0a0M3Tiw4TKPXBpL0kP73HYmBNLvLo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , Douglas Miller , "David S. Miller" , netdev@vger.kernel.org, "Sasha Levin (Microsoft)" Subject: [PATCH 3.18 21/86] net: ibm: fix possible object reference leak Date: Wed, 15 May 2019 12:54:58 +0200 Message-Id: <20190515090646.852161099@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090642.339346723@linuxfoundation.org> References: <20190515090642.339346723@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org [ Upstream commit be693df3cf9dd113ff1d2c0d8150199efdba37f6 ] The call to ehea_get_eth_dn returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/net/ethernet/ibm/ehea/ehea_main.c:3163:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3154, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Douglas Miller Cc: "David S. Miller" Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (Microsoft) --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 566b17db135a..a718066bb99f 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c @@ -3183,6 +3183,7 @@ static ssize_t ehea_probe_port(struct device *dev, if (ehea_add_adapter_mr(adapter)) { pr_err("creating MR failed\n"); + of_node_put(eth_dn); return -EIO; } -- 2.19.1