From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1989FC04E53 for ; Wed, 15 May 2019 12:12:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2B6720657 for ; Wed, 15 May 2019 12:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557922342; bh=cD5JqFBtKTIau3fJSKafXbZC7LycYSi3He4kA02A0WI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lvKk66m7Pls6HEwzZJAxPRbWyScYTVniCh+moktWyABxXMmnL/BRdeES+G1INo/G8 bXm3O61MKcP3R42kHNgOz+34+5yeCQG2hHBuVYACpZPLxxYDNHMrPQllwIq1HfIBOv 0OLGkJZPKtf4lCuXUrFFihbmIIKYFm/8qKeK33YI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728689AbfEOLGC (ORCPT ); Wed, 15 May 2019 07:06:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:36466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728081AbfEOLGB (ORCPT ); Wed, 15 May 2019 07:06:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15B1E2173C; Wed, 15 May 2019 11:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557918360; bh=cD5JqFBtKTIau3fJSKafXbZC7LycYSi3He4kA02A0WI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZDrlSD0cnxqCbx8vskXsP6NfmMNx2cWBLXs9ckdzloZbaDTY3oVIcrGZXE68NVeNX dJbsG3BjcLR4PVWAWjtiG8bQgjfyDm8nGEBjXbV9CWTLTZ1/WfomKFAYcE1v0ZdBl6 28uIh/8kYwEcy2datxKpfCUSj0rzdVc4EPMu8zsM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , Anirudha Sarangi , John Linn , "David S. Miller" , Michal Simek , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Sasha Levin (Microsoft)" Subject: [PATCH 4.4 100/266] net: xilinx: fix possible object reference leak Date: Wed, 15 May 2019 12:53:27 +0200 Message-Id: <20190515090725.833423228@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090722.696531131@linuxfoundation.org> References: <20190515090722.696531131@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org [ Upstream commit fa3a419d2f674b431d38748cb58fb7da17ee8949 ] The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1624:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1569, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Anirudha Sarangi Cc: John Linn Cc: "David S. Miller" Cc: Michal Simek Cc: netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (Microsoft) --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 4684644703cc..58ba579793f8 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1595,12 +1595,14 @@ static int axienet_probe(struct platform_device *pdev) ret = of_address_to_resource(np, 0, &dmares); if (ret) { dev_err(&pdev->dev, "unable to get DMA resource\n"); + of_node_put(np); goto free_netdev; } lp->dma_regs = devm_ioremap_resource(&pdev->dev, &dmares); if (IS_ERR(lp->dma_regs)) { dev_err(&pdev->dev, "could not map DMA regs\n"); ret = PTR_ERR(lp->dma_regs); + of_node_put(np); goto free_netdev; } lp->rx_irq = irq_of_parse_and_map(np, 1); -- 2.19.1