From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10A60C04E53 for ; Wed, 15 May 2019 12:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5D6520657 for ; Wed, 15 May 2019 12:12:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557922338; bh=lEScbHYxluGdltb6WaLMVXyovCy9UK4iGpChjFmlZ0g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XzzqauHUR9VXSUwk9StvF7VBXTZqoKMmpoTWTaXP1yGb8YQbIzvkIF9+iSyZSmgX7 3csUbQz94Tvdkk/msP3h3snp8/EwAPuSt25Sg/URKO0NtXC1rV5Mpl8Wb37oW3Zfay qUuE69oUEwDwKuZqo2/wUlIksR7CefA/sZTfi0jw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728936AbfEOMMO (ORCPT ); Wed, 15 May 2019 08:12:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:36520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728696AbfEOLGD (ORCPT ); Wed, 15 May 2019 07:06:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D01320881; Wed, 15 May 2019 11:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557918363; bh=lEScbHYxluGdltb6WaLMVXyovCy9UK4iGpChjFmlZ0g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p3i5aIF3EyykZrkwOmH7W+Q4+i/iwLogpml+t2oyyxgZQX6FmOJkw5clJ25Ia2VSk VySDe1DvI4EBzo1njptXByq1KVy8Ys++LtYU1KBckSv8fscETtkT0zQrSqWaqHtpWZ 6O4JH0buVreRYcV5oSzA7Zr5a5nyqMruxGFGEFA4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , Douglas Miller , "David S. Miller" , netdev@vger.kernel.org, "Sasha Levin (Microsoft)" Subject: [PATCH 4.4 101/266] net: ibm: fix possible object reference leak Date: Wed, 15 May 2019 12:53:28 +0200 Message-Id: <20190515090725.867665994@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090722.696531131@linuxfoundation.org> References: <20190515090722.696531131@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org [ Upstream commit be693df3cf9dd113ff1d2c0d8150199efdba37f6 ] The call to ehea_get_eth_dn returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/net/ethernet/ibm/ehea/ehea_main.c:3163:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3154, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Douglas Miller Cc: "David S. Miller" Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (Microsoft) --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 2a0dc127df3f..1a56de06b014 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c @@ -3183,6 +3183,7 @@ static ssize_t ehea_probe_port(struct device *dev, if (ehea_add_adapter_mr(adapter)) { pr_err("creating MR failed\n"); + of_node_put(eth_dn); return -EIO; } -- 2.19.1