* FW: [PATCH] net: phy: aquantia: readd XGMII support for AQR107 [not found] <VI1PR04MB5567F06E7A9B5CC8B2E4854CEC090@VI1PR04MB5567.eurprd04.prod.outlook.com> @ 2019-05-15 8:46 ` Madalin-cristian Bucur 2019-05-15 12:36 ` Andrew Lunn 2019-05-15 17:30 ` Heiner Kallweit 0 siblings, 2 replies; 3+ messages in thread From: Madalin-cristian Bucur @ 2019-05-15 8:46 UTC (permalink / raw) To: netdev@vger.kernel.org Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net XGMII interface mode no longer works on AQR107 after the recent changes, adding back support. Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- drivers/net/phy/aquantia_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c index eed4fe3d871f..0fedd28fdb6e 100644 --- a/drivers/net/phy/aquantia_main.c +++ b/drivers/net/phy/aquantia_main.c @@ -487,6 +487,7 @@ static int aqr107_config_init(struct phy_device *phydev) /* Check that the PHY interface type is compatible */ if (phydev->interface != PHY_INTERFACE_MODE_SGMII && phydev->interface != PHY_INTERFACE_MODE_2500BASEX && + phydev->interface != PHY_INTERFACE_MODE_XGMII && phydev->interface != PHY_INTERFACE_MODE_10GKR) return -ENODEV; -- 2.1.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: FW: [PATCH] net: phy: aquantia: readd XGMII support for AQR107 2019-05-15 8:46 ` FW: [PATCH] net: phy: aquantia: readd XGMII support for AQR107 Madalin-cristian Bucur @ 2019-05-15 12:36 ` Andrew Lunn 2019-05-15 17:30 ` Heiner Kallweit 1 sibling, 0 replies; 3+ messages in thread From: Andrew Lunn @ 2019-05-15 12:36 UTC (permalink / raw) To: Madalin-cristian Bucur Cc: netdev@vger.kernel.org, hkallweit1@gmail.com, davem@davemloft.net On Wed, May 15, 2019 at 08:46:26AM +0000, Madalin-cristian Bucur wrote: > XGMII interface mode no longer works on AQR107 after the recent changes, > adding back support. Hi Madalin Please provide a Fixes: tag for fixes like this: Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init") I will let Heiner actually review it. Andrew ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: FW: [PATCH] net: phy: aquantia: readd XGMII support for AQR107 2019-05-15 8:46 ` FW: [PATCH] net: phy: aquantia: readd XGMII support for AQR107 Madalin-cristian Bucur 2019-05-15 12:36 ` Andrew Lunn @ 2019-05-15 17:30 ` Heiner Kallweit 1 sibling, 0 replies; 3+ messages in thread From: Heiner Kallweit @ 2019-05-15 17:30 UTC (permalink / raw) To: Madalin-cristian Bucur, netdev@vger.kernel.org Cc: andrew@lunn.ch, davem@davemloft.net On 15.05.2019 10:46, Madalin-cristian Bucur wrote: > XGMII interface mode no longer works on AQR107 after the recent changes, > adding back support. > I'd like to check the configuration of the system with the AQR107. Which board is it, and which DT config is used? > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > --- > drivers/net/phy/aquantia_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c > index eed4fe3d871f..0fedd28fdb6e 100644 > --- a/drivers/net/phy/aquantia_main.c > +++ b/drivers/net/phy/aquantia_main.c > @@ -487,6 +487,7 @@ static int aqr107_config_init(struct phy_device *phydev) > /* Check that the PHY interface type is compatible */ > if (phydev->interface != PHY_INTERFACE_MODE_SGMII && > phydev->interface != PHY_INTERFACE_MODE_2500BASEX && > + phydev->interface != PHY_INTERFACE_MODE_XGMII && > phydev->interface != PHY_INTERFACE_MODE_10GKR) > return -ENODEV; > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-15 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <VI1PR04MB5567F06E7A9B5CC8B2E4854CEC090@VI1PR04MB5567.eurprd04.prod.outlook.com>
2019-05-15 8:46 ` FW: [PATCH] net: phy: aquantia: readd XGMII support for AQR107 Madalin-cristian Bucur
2019-05-15 12:36 ` Andrew Lunn
2019-05-15 17:30 ` Heiner Kallweit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).