* [PATCH net-next] net: stmmac: socfpga: add RMII phy mode
@ 2019-05-15 14:46 Dinh Nguyen
2019-05-15 15:24 ` Andrew Lunn
2019-05-15 16:18 ` Florian Fainelli
0 siblings, 2 replies; 5+ messages in thread
From: Dinh Nguyen @ 2019-05-15 14:46 UTC (permalink / raw)
To: netdev; +Cc: dinguyen, davem, joabreu, Wei Liang Lim
Add option for enabling RMII phy mode.
Signed-off-by: Wei Liang Lim <wei.liang.lim@intel.com>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index d466e33635b0..75a6471db76c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(struct socfpga_dwmac *dwmac)
case PHY_INTERFACE_MODE_SGMII:
val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_GMII_MII;
break;
+ case PHY_INTERFACE_MODE_RMII:
+ val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RMII;
+ break;
default:
dev_err(dwmac->dev, "bad phy mode %d\n", phymode);
return -EINVAL;
--
2.20.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode
2019-05-15 14:46 [PATCH net-next] net: stmmac: socfpga: add RMII phy mode Dinh Nguyen
@ 2019-05-15 15:24 ` Andrew Lunn
2019-05-15 16:18 ` Florian Fainelli
2019-05-15 16:18 ` Florian Fainelli
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2019-05-15 15:24 UTC (permalink / raw)
To: Dinh Nguyen; +Cc: netdev, davem, joabreu, Wei Liang Lim
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(struct socfpga_dwmac *dwmac)
> case PHY_INTERFACE_MODE_SGMII:
> val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_GMII_MII;
> break;
> + case PHY_INTERFACE_MODE_RMII:
> + val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RMII;
> + break;
What about PHY_INTERFACE_MODE_RMII_ID, PHY_INTERFACE_MODE_RMII_RXID,
PHY_INTERFACE_MODE_RMII_TXID?
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode
2019-05-15 15:24 ` Andrew Lunn
@ 2019-05-15 16:18 ` Florian Fainelli
2019-05-15 16:30 ` Andrew Lunn
0 siblings, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2019-05-15 16:18 UTC (permalink / raw)
To: Andrew Lunn, Dinh Nguyen; +Cc: netdev, davem, joabreu, Wei Liang Lim
On 5/15/19 8:24 AM, Andrew Lunn wrote:
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(struct socfpga_dwmac *dwmac)
>> case PHY_INTERFACE_MODE_SGMII:
>> val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_GMII_MII;
>> break;
>> + case PHY_INTERFACE_MODE_RMII:
>> + val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RMII;
>> + break;
>
> What about PHY_INTERFACE_MODE_RMII_ID, PHY_INTERFACE_MODE_RMII_RXID,
> PHY_INTERFACE_MODE_RMII_TXID?
RMII is reduced MII not Reduced Gigabit MII (RGMII), which still
operates at MII speed, therefore no concept of internal deal for RX/TX
data lines, the change looks fine to me.
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode
2019-05-15 14:46 [PATCH net-next] net: stmmac: socfpga: add RMII phy mode Dinh Nguyen
2019-05-15 15:24 ` Andrew Lunn
@ 2019-05-15 16:18 ` Florian Fainelli
1 sibling, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2019-05-15 16:18 UTC (permalink / raw)
To: Dinh Nguyen, netdev; +Cc: davem, joabreu, Wei Liang Lim
On 5/15/19 7:46 AM, Dinh Nguyen wrote:
> Add option for enabling RMII phy mode.
>
> Signed-off-by: Wei Liang Lim <wei.liang.lim@intel.com>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode
2019-05-15 16:18 ` Florian Fainelli
@ 2019-05-15 16:30 ` Andrew Lunn
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2019-05-15 16:30 UTC (permalink / raw)
To: Florian Fainelli; +Cc: Dinh Nguyen, netdev, davem, joabreu, Wei Liang Lim
On Wed, May 15, 2019 at 09:18:15AM -0700, Florian Fainelli wrote:
> On 5/15/19 8:24 AM, Andrew Lunn wrote:
> >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> >> @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(struct socfpga_dwmac *dwmac)
> >> case PHY_INTERFACE_MODE_SGMII:
> >> val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_GMII_MII;
> >> break;
> >> + case PHY_INTERFACE_MODE_RMII:
> >> + val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RMII;
> >> + break;
> >
> > What about PHY_INTERFACE_MODE_RMII_ID, PHY_INTERFACE_MODE_RMII_RXID,
> > PHY_INTERFACE_MODE_RMII_TXID?
>
> RMII is reduced MII not Reduced Gigabit MII (RGMII), which still
> operates at MII speed, therefore no concept of internal deal for RX/TX
> data lines, the change looks fine to me.
Upps, yes. Missed the missing G!
Sorry for the noise.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-15 16:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-15 14:46 [PATCH net-next] net: stmmac: socfpga: add RMII phy mode Dinh Nguyen
2019-05-15 15:24 ` Andrew Lunn
2019-05-15 16:18 ` Florian Fainelli
2019-05-15 16:30 ` Andrew Lunn
2019-05-15 16:18 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).