From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B34AC04AAF for ; Thu, 16 May 2019 22:26:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5BAC2070D for ; Thu, 16 May 2019 22:26:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="MTf1wNO6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728204AbfEPW0J (ORCPT ); Thu, 16 May 2019 18:26:09 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:35392 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbfEPW0I (ORCPT ); Thu, 16 May 2019 18:26:08 -0400 Received: by mail-qt1-f193.google.com with SMTP id a39so5926768qtk.2 for ; Thu, 16 May 2019 15:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=z+lMxg6moxmVTJd4xVQUIKrnB2Pe9tq+zxdTiVlja5w=; b=MTf1wNO6dvAlBq4uNVTjRNWaxh4yaUhpjLTjAZNM9kE8rSBohB9ikhQ3Owr1aXlcoW M5peoCV2r+v3J6nIlgGCXGgeqZKLAPOTKACuGmx0SEehA3V+ZS+IR8EQWvVlJXcqvAbj gHauAt2j/yDWNyFDydZcguKWQmG5qvJO77ytYBpVNaQOtzqaKQAzZryooTDnD66TbAEq tx9aSyREjjUQ0OVW+dPm8CyJjfbL9JhnYdvAKZ3WqXY1MB0tQIGpTBeWMMxGlwn1VeXx EXevU+vnSoNtvmGvZH3YY4e8lvq/8h9pM0tZNa9zsWa2Xfp0P3tuX4ZrlxX+efULz3jT /3Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=z+lMxg6moxmVTJd4xVQUIKrnB2Pe9tq+zxdTiVlja5w=; b=qpNmLk3J7u4KP3mXZs6VYEVPUjThD9N0w40IIfr3yQcRDhdOY3hXZX1bYu61mwdZ1O IMQ3pVckidVxZ3Rmf50lk+SJtTAwEw5e7srRzyaWnuDCyTgEt8JU67C3pIGZ0YrFu8C7 e8cE1ySSzfmHkPj6scqRG+YKn42rnN+Aym4EPxggB8QDnAr9527GkzhXu5JM3VVGIDpV glRLtvUb/Rzqt5bW8ymXHj0tdJtWgbygZpX4GUAWtZlltLLuHlIIPkIrTtXoUo3sWhjH 869Ciukbjlo3+dVgd+elb+e7dCWTk9updLOuu1Fiw+5isjF2Ac483l85oSIdNqTAaZUb s2jQ== X-Gm-Message-State: APjAAAVPsL/P3ZdvHj2WQTcYgWzN7AzZiTsfBO9jwveI4U4TWI0Nj9sm O4aZw+frwZE8xqMRG9SByzJCdQ== X-Google-Smtp-Source: APXvYqwx6f05U0rLdKo7dKtBI03oGXhaY7wNIC+vWT/02Xp80EXjqg9DD+ESWOMJaOFeVF1ArVj8hw== X-Received: by 2002:a0c:89e8:: with SMTP id 37mr9622340qvs.190.1558045567951; Thu, 16 May 2019 15:26:07 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id w195sm3369737qkb.54.2019.05.16.15.26.07 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 16 May 2019 15:26:07 -0700 (PDT) Date: Thu, 16 May 2019 15:25:43 -0700 From: Jakub Kicinski To: Stephen Hemminger Cc: netdev@vger.kernel.org, davem@davemloft.net, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org, Stephen Hemminger Subject: Re: [PATCH net 3/3] netdevice: clarify meaning of rx_handler_result Message-ID: <20190516152543.729c6cb0@cakuba.netronome.com> In-Reply-To: <20190516215423.14185-4-sthemmin@microsoft.com> References: <20190516215423.14185-1-sthemmin@microsoft.com> <20190516215423.14185-4-sthemmin@microsoft.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 16 May 2019 14:54:23 -0700, Stephen Hemminger wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 44b47e9df94a..56f613561909 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -374,10 +374,10 @@ typedef enum gro_result gro_result_t; > > /* > * enum rx_handler_result - Possible return values for rx_handlers. > - * @RX_HANDLER_CONSUMED: skb was consumed by rx_handler, do not process it > - * further. > - * @RX_HANDLER_ANOTHER: Do another round in receive path. This is indicated in > - * case skb->dev was changed by rx_handler. > + * @RX_HANDLER_CONSUMED: skb was consumed by rx_handler. > + * Do not process it further. > + * @RX_HANDLER_ANOTHER: skb->dev was modified by rx_handler, > + * Do another round in receive path. This is indicated in s/ This is indicated in// > * @RX_HANDLER_EXACT: Force exact delivery, no wildcard. > * @RX_HANDLER_PASS: Do nothing, pass the skb as if no rx_handler was called. > *