From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsahern@gmail.com>
Cc: Nir Weiner <nir.weiner@oracle.com>,
netdev@vger.kernel.org, liran.alon@oracle.com
Subject: Re: [iproute2 2/3] tc: jsonify tbf qdisc parameters
Date: Fri, 17 May 2019 10:57:51 -0700 [thread overview]
Message-ID: <20190517105751.7d5a7907@hermes.lan> (raw)
In-Reply-To: <a60c8e21-28bf-294c-7e3d-612493346bbb@gmail.com>
On Fri, 17 May 2019 11:35:16 -0600
David Ahern <dsahern@gmail.com> wrote:
> On 5/6/19 10:18 AM, Nir Weiner wrote:
>
> > if (prate64) {
> > - fprintf(f, "peakrate %s ", sprint_rate(prate64, b1));
> > + print_string(PRINT_ANY, "peakrate", "peakrate %s ", sprint_rate(prate64, b1));
> > if (qopt->mtu || qopt->peakrate.mpu) {
> > mtu = tc_calc_xmitsize(prate64, qopt->mtu);
> > if (show_details) {
> > fprintf(f, "mtu %s/%u mpu %s ", sprint_size(mtu, b1),
> > 1<<qopt->peakrate.cell_log, sprint_size(qopt->peakrate.mpu, b2));
>
>
> The fprintf under show_details should be converted as well. This applies
> to patch 1 as well.
>
> And, please add example output to each patch.
One trick I used was scanning for all calls to fprintf(f and replacing them
next prev parent reply other threads:[~2019-05-17 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 16:18 [iproute2 0/3] Adding json support for showing htb&tbf classes Nir Weiner
2019-05-06 16:18 ` [iproute2 1/3] tc: jsonify htb qdisc parameters Nir Weiner
2019-05-06 16:18 ` [iproute2 2/3] tc: jsonify tbf " Nir Weiner
2019-05-17 17:35 ` David Ahern
2019-05-17 17:57 ` Stephen Hemminger [this message]
2019-05-06 16:18 ` [iproute2 3/3] tc: jsonify class core Nir Weiner
2019-05-06 16:22 ` [iproute2 0/3] Adding json support for showing htb&tbf classes Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517105751.7d5a7907@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=liran.alon@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=nir.weiner@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).