From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 740EFC04AB4 for ; Fri, 17 May 2019 21:20:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DDBD2087B for ; Fri, 17 May 2019 21:20:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="YrhFKSN2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbfEQVUK (ORCPT ); Fri, 17 May 2019 17:20:10 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38701 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbfEQVUJ (ORCPT ); Fri, 17 May 2019 17:20:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vWNBmZaoo6h8PhQPos96OVGTC8ag0hj9BvGmBslFh5s=; b=YrhFKSN26z9kCYRl0BPeMZnmnI pQbSrya21Qri4trQIfDkCeFp5emc2IHSYi8zwrUGvO7R48Q3U6K8MIOBrfsO35NPFK49DuZbJ4mYL YDE0vUhX/2IcyVHxhCLIYaPIsLFwsFvf4E6C6J4ctwQI/UyZGeqma/5YJVsu6liEXEVw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hRkGp-0008K9-0I; Fri, 17 May 2019 23:20:03 +0200 Date: Fri, 17 May 2019 23:20:02 +0200 From: Andrew Lunn To: Michael Schmitz Cc: netdev@vger.kernel.org, schmitz@debian.org, sfr@canb.auug.org.au, davem@davemloft.net Subject: Re: [PATCH 0/3] resolve module name conflict for asix PHY and USB modules Message-ID: <20190517212002.GA22024@lunn.ch> References: <20190514105649.512267cd@canb.auug.org.au> <1558124718-19209-1-git-send-email-schmitzmic@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1558124718-19209-1-git-send-email-schmitzmic@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, May 18, 2019 at 08:25:15AM +1200, Michael Schmitz wrote: > Haven't heard back in a while, so here goes: > > Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") > introduced a new PHY driver drivers/net/phy/asix.c that causes a module > name conflict with a pre-existiting driver (drivers/net/usb/asix.c). > > The PHY driver is used by the X-Surf 100 ethernet card driver, and loaded > by that driver via its PHY ID. A rename of the driver looks unproblematic. > > Rename PHY driver to ax88796b.c in order to resolve name conflict. Hi Michael Please just use git mv and do it all one patch. It then makes it clear you have not changed the driver, just renamed it. Thanks Andrew