From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03BE9C04AAF for ; Mon, 20 May 2019 09:04:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC35A20856 for ; Mon, 20 May 2019 09:04:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558343075; bh=1v1nuxcWvVkGGL35WWUJOcGwdr8fXibrkPbcNDFvVL0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uQFwuWSzU2C1r4gz49C9KhC6odtmHV5+IqGtvblX7uHaz/iyksvSRwW8vfsUc585i 6YczaAAdxDoVwS6qZlT0HKy5om324BeZrJekULa0ShabJHYIaN00Dh9IRWkn+KTRj+ /5xM0ewCLWfZmV/7pz6ad38guQkqtdsy1touz2aI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731658AbfETJEc (ORCPT ); Mon, 20 May 2019 05:04:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:33068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727301AbfETJEc (ORCPT ); Mon, 20 May 2019 05:04:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2691320644; Mon, 20 May 2019 09:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558343071; bh=1v1nuxcWvVkGGL35WWUJOcGwdr8fXibrkPbcNDFvVL0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NPOwRyQ8bLcCg+3pJW3uPJDmS6TfkstyMWu4M4AsILKZ5dCJOQpzgR72fm0961qvy 6Jy3L8eYoqKg6hXPwXh5j81CL1iGbTQzL32NPTzcdcCO04U6Qa+pBVeziWzm1OOf4j LqSm+oD69YCYQBlyT7SJhf5gKeMcTJfHB/K6r4YI= Date: Mon, 20 May 2019 11:04:29 +0200 From: Greg Kroah-Hartman To: David Ahern Cc: Nathan Chancellor , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Thomas Haller , Hangbin Liu , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH 4.9 41/51] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied Message-ID: <20190520090429.GA25812@kroah.com> References: <20190515090616.669619870@linuxfoundation.org> <20190515090628.066392616@linuxfoundation.org> <20190519154348.GA113991@archlinux-epyc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, May 19, 2019 at 06:29:19PM -0600, David Ahern wrote: > On 5/19/19 9:43 AM, Nathan Chancellor wrote: > > Hi all, > > > > This commit is causing issues on Android devices when Wi-Fi and mobile > > data are both enabled. The device will do a soft reboot consistently. > > So far, I've had reports on the Pixel 3 XL, OnePlus 6, Pocophone, and > > Note 9 and I can reproduce on my OnePlus 6. > > > > Sorry for taking so long to report this, I just figured out how to > > reproduce it today and I didn't want to report it without that. > > > > Attached is a full dmesg and the relevant snippet from Android's logcat. > > > > Let me know what I can do to help debug, > > Nathan > > > > It's a backport problem. err needs to be reset to 0 before the goto. Ah, I see it, let me go queue up a fix for this. thanks, greg k-h