From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 393A3C04E87 for ; Tue, 21 May 2019 14:46:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F9D12173E for ; Tue, 21 May 2019 14:46:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="L8ycAEtU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728559AbfEUOqC (ORCPT ); Tue, 21 May 2019 10:46:02 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44028 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728055AbfEUOqC (ORCPT ); Tue, 21 May 2019 10:46:02 -0400 Received: by mail-pl1-f193.google.com with SMTP id gn7so4399013plb.10 for ; Tue, 21 May 2019 07:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=de3y25UgGac49MbnsF0R7E+4373Q0F2/TDUFzvPVXAQ=; b=L8ycAEtULq2ubg26UmaLuj4uEu9FAeWattAev83ZQ2i4zEQtnAhGDcPbC5O04DlPdW L+kLP9LaUOoJTJQ+DeqQVXcRmzG6sH7p3qS5Suxre+uO9lkoACfmuiN6MbvSNHyT0ErO pI8hy0AauF6trTVMRLRfgf9UjUTwHyx1q4uVPID9NeWYiW4C0L9reFbO/szdOe6L9++B 9R86QOmDu/h25eHiKHEovIHNA3j1dRmbaRoG9unkVNqmPv4gmlXHSwWcD/PID6+Y4EXY e6FiclMqCtIJ50e/qHZEbd8RRGnWm0zg46IevhewkTAs4jBjaPcwwJK0cC3jTsp8K3EN cLEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=de3y25UgGac49MbnsF0R7E+4373Q0F2/TDUFzvPVXAQ=; b=UMahzOp/V3XHwWlJ/SOsb+UczJCCCiZClLbuNkBFswwwsjKdpS546Tei87ElDJncgq 6pNBvD6FZ7CrWFwtOQfyP/AQ9gJPJJsAdYdvbEWldUTtDa8MhMe8RJR9YVmW2GWal6Fv 2qlcrsWAet1MnXIvm0MnJtnBxz6gvgofQwoL3Us1Dp7q1H+kzEtdPaRcz9kzpfNTYT7s RhS4MQmKo6cTHP4G3XmJ7FJwTwfksdCsioW/q0XvxOZtxKamH6PlHmYBX/cOocNVt33t 4rMR65tjZcv9jWAeMFXdTjg/Hn3k1IZvyfB/8WJXEWtTNYkuj0QrSIqbw6dSVHaeslwI /zXg== X-Gm-Message-State: APjAAAV9qPWyh14kWmtgqTUjvTOW9wIn9n8SvASssd+KbqkeWrERtTJV Awov/fIgCSJ6qKzp0R3nlqqFdg== X-Google-Smtp-Source: APXvYqxL/kfPI/S/85HWsxZoJyfotngXhLZjk5iXQHZLDkK56y9TdDhMYM5qUophLBH2N2/83N6pNA== X-Received: by 2002:a17:902:f24:: with SMTP id 33mr82347752ply.33.1558449961295; Tue, 21 May 2019 07:46:01 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 7sm1948070pfo.90.2019.05.21.07.46.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 May 2019 07:46:01 -0700 (PDT) Date: Tue, 21 May 2019 07:45:53 -0700 From: Stephen Hemminger To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org, Stephen Hemminger , Jason Wang Subject: Re: [PATCH v2 net 2/2] net: core: generic XDP support for stacked device Message-ID: <20190521074553.12329dd5@hermes.lan> In-Reply-To: <20190521061536.GB2210@nanopsycho.orion> References: <20190519031046.4049-1-sthemmin@microsoft.com> <20190519031046.4049-3-sthemmin@microsoft.com> <20190520091105.GA2142@nanopsycho> <20190520090405.69b419e5@hermes.lan> <20190521061536.GB2210@nanopsycho.orion> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 21 May 2019 08:15:36 +0200 Jiri Pirko wrote: > + if (static_branch_unlikely(&generic_xdp_needed_key)) { > + int ret2; > + > + preempt_disable(); > + rcu_read_lock(); > + ret2 = do_xdp_generic(rcu_dereference(skb->dev->xdp_prog), skb); > + rcu_read_unlock(); > + preempt_enable(); > + > + if (ret2 != XDP_PASS) > + return NET_RX_DROP; > + } > + rcu_read_lock is already held by callers of __netif_receive_skb_core