public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: maximmi@mellanox.com
Cc: jakub.kicinski@netronome.com, kuznet@ms2.inr.ac.ru,
	yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
	leonro@mellanox.com
Subject: Re: [PATCH net v2] Validate required parameters in inet6_validate_link_af
Date: Wed, 22 May 2019 12:07:48 -0700 (PDT)	[thread overview]
Message-ID: <20190522.120748.42244348495685617.davem@davemloft.net> (raw)
In-Reply-To: <20190521063941.7451-1-maximmi@mellanox.com>

From: Maxim Mikityanskiy <maximmi@mellanox.com>
Date: Tue, 21 May 2019 06:40:04 +0000

> inet6_set_link_af requires that at least one of IFLA_INET6_TOKEN or
> IFLA_INET6_ADDR_GET_MODE is passed. If none of them is passed, it
> returns -EINVAL, which may cause do_setlink() to fail in the middle of
> processing other commands and give the following warning message:
> 
>   A link change request failed with some changes committed already.
>   Interface eth0 may have been left with an inconsistent configuration,
>   please check.
> 
> Check the presence of at least one of them in inet6_validate_link_af to
> detect invalid parameters at an early stage, before do_setlink does
> anything. Also validate the address generation mode at an early stage.
> 
> Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>

Applied, thank you.

  reply	other threads:[~2019-05-22 19:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  6:40 [PATCH net v2] Validate required parameters in inet6_validate_link_af Maxim Mikityanskiy
2019-05-22 19:07 ` David Miller [this message]
2019-07-09  1:11   ` Stefan Lippers-Hollmann
2019-07-10  9:36     ` Maxim Mikityanskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522.120748.42244348495685617.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=leonro@mellanox.com \
    --cc=maximmi@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox