From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EC26C282CE for ; Thu, 23 May 2019 00:29:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C138E21019 for ; Thu, 23 May 2019 00:29:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728668AbfEWA3u (ORCPT ); Wed, 22 May 2019 20:29:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36592 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727634AbfEWA3u (ORCPT ); Wed, 22 May 2019 20:29:50 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8D44E15042888; Wed, 22 May 2019 17:29:49 -0700 (PDT) Date: Wed, 22 May 2019 17:29:48 -0700 (PDT) Message-Id: <20190522.172948.1674625854915710265.davem@davemloft.net> To: Jisheng.Zhang@synaptics.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: fix reset gpio free missing From: David Miller In-Reply-To: <20190522175558.59b21673@xhacker.debian> References: <20190522175558.59b21673@xhacker.debian> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 May 2019 17:29:49 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jisheng Zhang Date: Wed, 22 May 2019 10:05:09 +0000 > Commit 984203ceff27 ("net: stmmac: mdio: remove reset gpio free") > removed the reset gpio free, when the driver is unbinded or rmmod, > we miss the gpio free. > > This patch uses managed API to request the reset gpio, so that the > gpio could be freed properly. > > Signed-off-by: Jisheng Zhang > Fixes: 984203ceff27 ("net: stmmac: mdio: remove reset gpio free") Please put the Fixes: tag first in the list of tags in the future. Applied, thank you.