From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: "Ulrich Hecht" <uli@fpond.eu>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, magnus.damm@gmail.com
Subject: Re: [PATCH] ravb: implement MTU change while device is up
Date: Wed, 22 May 2019 13:59:16 +0200 [thread overview]
Message-ID: <20190522115916.vlnbna2vxnf7zhod@verge.net.au> (raw)
In-Reply-To: <20190520120954.ffz2ius5nvojkxlh@katana>
On Mon, May 20, 2019 at 02:09:54PM +0200, Wolfram Sang wrote:
>
> > > > > > > How about the code below instead?
> > > > > > >
> > > > > > > if (netif_running(ndev))
> > > > > > > ravb_close(ndev);
> > > > > > >
> > > > > > > ndev->mtu = new_mtu;
> > > > > > > netdev_update_features(ndev);
> > > > > >
> > > > > > Is there a need to call netdev_update_features() even if the if is not
> > > > > > running?
> > > > >
> > > > > In my testing, it didn't seem so.
> > > >
> > > > That may be because your testing doesn't cover cases where it would make
> > > > any difference.
> > >
> > > Cases other than changing the MTU while the device is up?
> >
> > I was thinking of cases where listeners are registered for the
> > notifier that netdev_update_features() triggers.
>
> Where are we here? Is this a blocker?
I don't think this is a blocker but I would lean towards leaving
netdev_update_features() in unless we are certain its not needed.
next prev parent reply other threads:[~2019-05-22 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 15:21 [PATCH] ravb: implement MTU change while device is up Ulrich Hecht
2019-05-08 15:59 ` Sergei Shtylyov
2019-05-08 16:52 ` Niklas Söderlund
2019-05-09 6:57 ` Ulrich Hecht
2019-05-09 10:10 ` Simon Horman
2019-05-09 15:32 ` Ulrich Hecht
2019-05-13 12:18 ` Simon Horman
2019-05-20 12:09 ` Wolfram Sang
2019-05-22 11:59 ` Simon Horman [this message]
2019-05-23 1:02 ` Ulrich Hecht
2019-05-08 16:50 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522115916.vlnbna2vxnf7zhod@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=uli@fpond.eu \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox