From: Vishal Kulkarni <vishal@chelsio.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>,
Indranil Choudhury <indranil@chelsio.com>, dt <dt@chelsio.com>
Subject: Re: [PATCH net-next] cxgb4: Revert "cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size"
Date: Wed, 22 May 2019 20:22:37 +0530 [thread overview]
Message-ID: <20190522145235.GA8075@chelsio.com> (raw)
In-Reply-To: <20190521.132331.1475679105999327536.davem@davemloft.net>
Hi David,
On Wednesday, May 05/22/19, 2019 at 01:53:31 +0530, David Miller wrote:
> From: Vishal Kulkarni <vishal@chelsio.com>
> Date: Tue, 21 May 2019 09:12:02 +0530
>
> > This reverts commit 2391b0030e241386d710df10e53e2cfc3c5d4fc1
> > SGE's BAR2 Doorbell/GTS Page Size is now interpreted correctly in the
> > firmware itself by using actual host page size. Hence previous commit
> > needs to be reverted.
> >
> > Signed-off-by: Vishal Kulkarni <vishal@chelsio.com>
>
> Really confusing.
>
> First of all, I see a lot of cxgb4 patch submissions targetting net-next that
> are really legitimate bug fixes.
>
> Are you only targetting net-next to be "on the safe side" because you are
> unsure of the 'net' rules? Please don't do that. If it's a bug fix, send
> it to 'net' as appropriate.
My apologies. I will retarget to 'net' and resend.
>
> Second, so what happens to people running older firmware? Have you made a
> completely incompatible change to the firmware behavior? If so, you have
> to version check the firmware and use the correct interpretation based upon
> how the firmware verion interprets things.
The fix in the commit 2391b0030e241386d710df10e53e2cfc3c5d4fc1 is wrong
and introduced regression. The correct fix is done in the firmware and
hence it needs to be reverted. The changes done in firmware is compatible.
>
> Thanks.
prev parent reply other threads:[~2019-05-22 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 3:42 [PATCH net-next] cxgb4: Revert "cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size" Vishal Kulkarni
2019-05-21 20:23 ` David Miller
2019-05-22 14:52 ` Vishal Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522145235.GA8075@chelsio.com \
--to=vishal@chelsio.com \
--cc=davem@davemloft.net \
--cc=dt@chelsio.com \
--cc=indranil@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).