From: Andrew Lunn <andrew@lunn.ch>
To: Trent Piepho <tpiepho@impinj.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH net-next v2 2/8] dt-bindings: phy: dp83867: Add documentation for disabling clock output
Date: Wed, 22 May 2019 21:11:48 +0200 [thread overview]
Message-ID: <20190522191148.GH7281@lunn.ch> (raw)
In-Reply-To: <20190522184255.16323-2-tpiepho@impinj.com>
On Wed, May 22, 2019 at 06:43:21PM +0000, Trent Piepho wrote:
> The clock output is generally only used for testing and development and
> not used to daisy-chain PHYs. It's just a source of RF noise afterward.
>
> Add a mux value for "off". I've added it as another enumeration to the
> output property. In the actual PHY, the mux and the output enable are
> independently controllable. However, it doesn't seem useful to be able
> to describe the mux setting when the output is disabled.
>
> Document that PHY's default setting will be left as is if the property
> is omitted.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-05-22 19:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 18:43 [PATCH net-next v2 1/8] dt-bindings: phy: dp83867: Describe how driver behaves w.r.t rgmii delay Trent Piepho
2019-05-22 18:43 ` [PATCH net-next v2 2/8] dt-bindings: phy: dp83867: Add documentation for disabling clock output Trent Piepho
2019-05-22 19:11 ` Andrew Lunn [this message]
2019-05-23 0:44 ` David Miller
2019-05-22 18:43 ` [PATCH net-next v2 3/8] net: phy: dp83867: Add ability to disable output clock Trent Piepho
2019-05-22 18:51 ` Andrew Lunn
2019-05-23 0:44 ` David Miller
2019-05-22 18:43 ` [PATCH net-next v2 4/8] net: phy: dp83867: Rework delay rgmii delay handling Trent Piepho
2019-05-22 18:54 ` Andrew Lunn
2019-05-23 0:44 ` David Miller
2019-05-22 18:43 ` [PATCH net-next v2 5/8] net: phy: dp83867: Use unsigned variables to store unsigned properties Trent Piepho
2019-05-22 18:59 ` Andrew Lunn
2019-05-23 0:44 ` David Miller
2019-05-22 18:43 ` [PATCH net-next v2 6/8] net: phy: dp83867: IO impedance is not dependent on RGMII delay Trent Piepho
2019-05-22 19:03 ` Andrew Lunn
2019-05-23 0:44 ` David Miller
2019-05-22 18:43 ` [PATCH net-next v2 7/8] net: phy: dp83867: Validate FIFO depth property Trent Piepho
2019-05-22 19:05 ` Andrew Lunn
2019-05-23 0:44 ` David Miller
2019-05-22 18:43 ` [PATCH net-next v2 8/8] net: phy: dp83867: Allocate state struct in probe Trent Piepho
2019-05-22 19:09 ` Andrew Lunn
2019-05-23 0:44 ` David Miller
2019-05-22 19:10 ` [PATCH net-next v2 1/8] dt-bindings: phy: dp83867: Describe how driver behaves w.r.t rgmii delay Andrew Lunn
2019-05-23 0:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522191148.GH7281@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).