From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25846C282DD for ; Thu, 23 May 2019 16:11:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 036E62175B for ; Thu, 23 May 2019 16:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731075AbfEWQLH (ORCPT ); Thu, 23 May 2019 12:11:07 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48160 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730782AbfEWQLH (ORCPT ); Thu, 23 May 2019 12:11:07 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2D9D21509A0F5; Thu, 23 May 2019 09:11:07 -0700 (PDT) Date: Thu, 23 May 2019 09:11:06 -0700 (PDT) Message-Id: <20190523.091106.645519899189717299.davem@davemloft.net> To: ast@domdv.de Cc: netdev@vger.kernel.org Subject: Re: [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs From: David Miller In-Reply-To: <32eb738a0a0f3ed5880911e4ac4ceedca76e3f52.camel@domdv.de> References: <32eb738a0a0f3ed5880911e4ac4ceedca76e3f52.camel@domdv.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 23 May 2019 09:11:07 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andreas Steinmetz Date: Thu, 23 May 2019 09:46:15 +0200 > MACsec causes oopses followed by a kernel panic when attached directly or indirectly to a bridge. It causes erroneous > checksum messages when attached to vxlan. When I did investigate I did find skb leaks, apparent skb mis-handling and > superfluous code. The attached patch fixes all MACsec misbehaviour I could find. As I am no kernel developer somebody > with sufficient kernel network knowledge should verify and correct the patch where necessary. > > Signed-off-by: Andreas Steinmetz Subject lines should be of the form: [PATCH $DST_TREE] $subsystem_prefix: Description. Where $DST_TREE here would be "net" and $subsystem_prefix would be "macsec". > + /* FIXME: any better way to prevent calls to netdev_rx_csum_fault? */ > + skb->csum_complete_sw = 1; Create a helper for this in linux/skbuff.h with very clear and clean comments explaining what is going on.