From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE64C072B5 for ; Fri, 24 May 2019 07:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BDE32168B for ; Fri, 24 May 2019 07:35:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388975AbfEXHfE (ORCPT ); Fri, 24 May 2019 03:35:04 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:55577 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388927AbfEXHfD (ORCPT ); Fri, 24 May 2019 03:35:03 -0400 X-Originating-IP: 90.88.147.134 Received: from localhost (aaubervilliers-681-1-27-134.w90-88.abo.wanadoo.fr [90.88.147.134]) (Authenticated sender: maxime.ripard@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id EDB8E40011; Fri, 24 May 2019 07:34:55 +0000 (UTC) Date: Fri, 24 May 2019 09:34:55 +0200 From: Maxime Ripard To: Alexandre Torgue Cc: Mark Rutland , Rob Herring , Frank Rowand , "David S . Miller" , Chen-Yu Tsai , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier , Antoine =?utf-8?Q?T=C3=A9nart?= Subject: Re: [PATCH 6/8] dt-bindings: net: stmmac: Convert the binding to a schemas Message-ID: <20190524073455.46auhvhwb5no6ebp@flea> References: <74d98cc3c744d53710c841381efd41cf5f15e656.1558605170.git-series.maxime.ripard@bootlin.com> <9094f39f-0e26-55dd-9b47-9a55089400da@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="23ickihnik62sivg" Content-Disposition: inline In-Reply-To: <9094f39f-0e26-55dd-9b47-9a55089400da@st.com> User-Agent: NeoMutt/20180716 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --23ickihnik62sivg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Alexandre, On Thu, May 23, 2019 at 05:05:51PM +0200, Alexandre Torgue wrote: > Hi Maxime > > On 5/23/19 11:56 AM, Maxime Ripard wrote: > > Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML > > schema to enable the DT validation. > > > > Signed-off-by: Maxime Ripard > > --- > > First, thanks a lot for this patch. Just one question: > We could add ranges for some properties in order to avoid "bad value" for a > property. If I understand correctly you do it only for snps,dwxgmac, > snps,dwxgmac-2.10 and st,spear600-gmac. Why not do it for all supported IPs > ? (Maybe it is something that we could add later) > We definitely can do that. It wasn't really obvious to me what the limits were by reading the previous documentation, but if you can provide them we can definitely add them. > > + snps,tso: > > + $ref: /schemas/types.yaml#definitions/flag > > + description: > > + Enables the TSO feature otherwise it will be managed by > > + MAC HW capability register. Only for GMAC4 and newer. > > TSO is also available for snps,dwmac-4.00 and snps,dwmac-4.10a Ack, I'll change it. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --23ickihnik62sivg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXOeenwAKCRDj7w1vZxhR xeATAQCcQsgy7vfEdnFVRTUYXu4cQi7yVev/HZ6IHxvhXUxohQEAlunQSSosiD+q hCssuxFFbw2++ejr0HSjYCaQvSZesQA= =FrHP -----END PGP SIGNATURE----- --23ickihnik62sivg--