From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B677C072B5 for ; Fri, 24 May 2019 09:59:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95D7C21773 for ; Fri, 24 May 2019 09:59:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=azazel.net header.i=@azazel.net header.b="EwOULvuG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390274AbfEXJ7b (ORCPT ); Fri, 24 May 2019 05:59:31 -0400 Received: from kadath.azazel.net ([81.187.231.250]:53990 "EHLO kadath.azazel.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389758AbfEXJ7b (ORCPT ); Fri, 24 May 2019 05:59:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=azazel.net; s=20190108; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VLi+bEG12+9e9R8ebYCZTJH1S8XSZcXZWJX7myl/K4c=; b=EwOULvuGhZQlPLPKIKuDhwVM2U wQ7XWFAzPJdT2u7fY61/VbTByw8FNmwVFIMF38OwlcNrkYr4Ddwbj6zH3OyXMRbeZ4QRNe0mbqu8O QkUljYOrVIPe0tYCxwYGRFXSu5GviLidjt28MF1/+8W9A037jESgyD1zMgHz9SrIzx4lfZn3yuBf1 vP8wHoBYPY2AG/gC0y/M4Zg9YMgzsANdUuVmZtMvk/8Hr9ov/ALvLXXJtJKRPNk85lR3h5jbIpe7e JcIAIYK3HbyvoQoyUACawUwFQojed8Bvmc/REZGB1xtV2zwSFnVqrlr5aMToXVCHhNyhZW6/oJEPt TpfGCrCA==; Received: from ulthar.dreamlands ([192.168.96.2]) by kadath.azazel.net with esmtp (Exim 4.89) (envelope-from ) id 1hU6z1-0002cj-F5; Fri, 24 May 2019 10:59:27 +0100 From: Jeremy Sowden To: b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, Marek Lindner , Simon Wunderlich , Antonio Quartulli , "David S. Miller" Cc: syzbot+d454a826e670502484b8@syzkaller.appspotmail.com, Sven Eckelmann Subject: [PATCH net v2] batman-adv: fix for leaked TVLV handler. Date: Fri, 24 May 2019 10:59:27 +0100 Message-Id: <20190524095927.31817-1-jeremy@azazel.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <3325808.M3JPgbICzP@bentobox> References: <3325808.M3JPgbICzP@bentobox> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 192.168.96.2 X-SA-Exim-Mail-From: jeremy@azazel.net X-SA-Exim-Scanned: No (on kadath.azazel.net); SAEximRunCond expanded to false Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org A handler for BATADV_TVLV_ROAM was being registered when the translation-table was initialized, but not unregistered when the translation-table was freed. Unregister it. Fixes: 122edaa05940 ("batman-adv: tvlv - convert roaming adv packet to use tvlv unicast packets") Reported-by: syzbot+d454a826e670502484b8@syzkaller.appspotmail.com Reviewed-by: Sven Eckelmann Signed-off-by: Jeremy Sowden --- Since v1. * Added "Fixes:" tag. * Added "Reviewed-by:" tag. * Changed prefix to "batman-adv:". net/batman-adv/translation-table.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 1ddfd5e011ee..8a482c5ec67b 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -3813,6 +3813,8 @@ static void batadv_tt_purge(struct work_struct *work) */ void batadv_tt_free(struct batadv_priv *bat_priv) { + batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_ROAM, 1); + batadv_tvlv_container_unregister(bat_priv, BATADV_TVLV_TT, 1); batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_TT, 1); -- 2.20.1