From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4413BC072B5 for ; Fri, 24 May 2019 10:09:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D7972175B for ; Fri, 24 May 2019 10:09:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390345AbfEXKJ0 (ORCPT ); Fri, 24 May 2019 06:09:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36938 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389806AbfEXKJ0 (ORCPT ); Fri, 24 May 2019 06:09:26 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA3F93004159; Fri, 24 May 2019 10:09:17 +0000 (UTC) Received: from bistromath.localdomain (unknown [10.36.118.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16545679D8; Fri, 24 May 2019 10:09:15 +0000 (UTC) Date: Fri, 24 May 2019 12:09:14 +0200 From: Sabrina Dubroca To: Andreas Steinmetz Cc: netdev@vger.kernel.org Subject: Re: [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs Message-ID: <20190524100914.GA20686@bistromath.localdomain> References: <32eb738a0a0f3ed5880911e4ac4ceedca76e3f52.camel@domdv.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <32eb738a0a0f3ed5880911e4ac4ceedca76e3f52.camel@domdv.de> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 24 May 2019 10:09:26 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Andreas, 2019-05-23, 09:46:15 +0200, Andreas Steinmetz wrote: > MACsec causes oopses followed by a kernel panic when attached > directly or indirectly to a bridge. It causes erroneous checksum > messages when attached to vxlan. It looks like you're fixing multiple separate bugs in a single patch, which makes it really difficult to understand. You're also not describing what the issues are, and why the changes you're proposing are fixing those bugs. Do you have reproducers for those bugs? That would be helpful, as I've never seen the panics/leaks/checksum issues you're mentioning. > When I did investigate I did find skb leaks, apparent skb mis-handling and > superfluous code. The attached patch fixes all MACsec misbehaviour I could find. Please fix only one issue per patch. Otherwise, it's really hard to tell what change fixes which issue. Thanks, -- Sabrina