From: Andrew Lunn <andrew@lunn.ch>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH V6] net: phy: tja11xx: Add TJA11xx PHY driver
Date: Fri, 24 May 2019 16:36:06 +0200 [thread overview]
Message-ID: <20190524143606.GN2979@lunn.ch> (raw)
In-Reply-To: <20190524142228.4003-1-marex@denx.de>
On Fri, May 24, 2019 at 04:22:28PM +0200, Marek Vasut wrote:
> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special
> BroadRReach 100BaseT1 PHYs used in automotive.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: linux-hwmon@vger.kernel.org
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> +static struct tja11xx_phy_stats tja11xx_hw_stats[] = {
> + { "phy_symbol_error_count", 20, 0, GENMASK(15, 0) },
> + { "phy_polarity_detect", 25, 6, BIT(6) },
> + { "phy_open_detect", 25, 7, BIT(7) },
> + { "phy_short_detect", 25, 8, BIT(8) },
> + { "phy_rem_rcvr_count", 26, 0, GENMASK(7, 0) },
> + { "phy_loc_rcvr_count", 26, 8, GENMASK(15, 8) },
> +};
I don't like phy_polarity_detect, phy_open_detect and phy_short_detect
since they are not actually counters. But we don't have cable test
support yet. That is coming soon, but it is hard to say when, if it
will get merged this cycle. So lets keep them, but don't be too
surprised if they get removed later.
Andrew
next prev parent reply other threads:[~2019-05-24 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 14:22 [PATCH V6] net: phy: tja11xx: Add TJA11xx PHY driver Marek Vasut
2019-05-24 14:36 ` Andrew Lunn [this message]
2019-05-26 20:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524143606.GN2979@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox