From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E6B8C282E1 for ; Fri, 24 May 2019 14:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D8E92081C for ; Fri, 24 May 2019 14:36:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="01B7wquO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404139AbfEXOgO (ORCPT ); Fri, 24 May 2019 10:36:14 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56140 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403997AbfEXOgO (ORCPT ); Fri, 24 May 2019 10:36:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3fJgvTqEhmBwQWcm4Ec4SKbVrWb5SDjuLaLyk06Zp2Y=; b=01B7wquOI6uQQAIirCyjpSwXbz nl6zSyrZOSxmzY/UUp4Q5FlKlIv5LTxypGJI/czt7WvtlUrQu1I8CdHNvaQMc+nOXoH+jO4ARLgAx QICRH/VVE/OJU/kGX3+TLA0AC2gM45XBWUEj1eNRgvhXlpgjtoMmQZ02Ue32Ew36Iivk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hUBIk-0001fA-Rm; Fri, 24 May 2019 16:36:06 +0200 Date: Fri, 24 May 2019 16:36:06 +0200 From: Andrew Lunn To: Marek Vasut Cc: netdev@vger.kernel.org, Florian Fainelli , Guenter Roeck , Heiner Kallweit , Jean Delvare , linux-hwmon@vger.kernel.org Subject: Re: [PATCH V6] net: phy: tja11xx: Add TJA11xx PHY driver Message-ID: <20190524143606.GN2979@lunn.ch> References: <20190524142228.4003-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190524142228.4003-1-marex@denx.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 24, 2019 at 04:22:28PM +0200, Marek Vasut wrote: > Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special > BroadRReach 100BaseT1 PHYs used in automotive. > > Signed-off-by: Marek Vasut > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Guenter Roeck > Cc: Heiner Kallweit > Cc: Jean Delvare > Cc: linux-hwmon@vger.kernel.org > Reviewed-by: Florian Fainelli Reviewed-by: Andrew Lunn > +static struct tja11xx_phy_stats tja11xx_hw_stats[] = { > + { "phy_symbol_error_count", 20, 0, GENMASK(15, 0) }, > + { "phy_polarity_detect", 25, 6, BIT(6) }, > + { "phy_open_detect", 25, 7, BIT(7) }, > + { "phy_short_detect", 25, 8, BIT(8) }, > + { "phy_rem_rcvr_count", 26, 0, GENMASK(7, 0) }, > + { "phy_loc_rcvr_count", 26, 8, GENMASK(15, 8) }, > +}; I don't like phy_polarity_detect, phy_open_detect and phy_short_detect since they are not actually counters. But we don't have cable test support yet. That is coming soon, but it is hard to say when, if it will get merged this cycle. So lets keep them, but don't be too surprised if they get removed later. Andrew