From: Max Uvarov <muvarov@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
davem@davemloft.net, Max Uvarov <muvarov@gmail.com>
Subject: [PATCH v2 4/4] net: phy: dp83867: Set up RGMII TX delay
Date: Mon, 27 May 2019 09:16:07 +0300 [thread overview]
Message-ID: <20190527061607.30030-5-muvarov@gmail.com> (raw)
In-Reply-To: <20190527061607.30030-1-muvarov@gmail.com>
PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
so code to set tx delay is never called.
Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy")
Signed-off-by: Max Uvarov <muvarov@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/dp83867.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index a1c0b2128de2..69e36d3d0968 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -251,10 +251,8 @@ static int dp83867_config_init(struct phy_device *phydev)
ret = phy_write(phydev, MII_DP83867_PHYCTRL, val);
if (ret)
return ret;
- }
- if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
- (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
+ /* Set up RGMII delays */
val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL);
if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
--
2.17.1
next prev parent reply other threads:[~2019-05-27 6:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 6:16 [PATCH v2 0/4] net: phy: dp83867: add some fixes Max Uvarov
2019-05-27 6:16 ` [PATCH v2 1/4] net: phy: dp83867: fix speed 10 in sgmii mode Max Uvarov
2019-05-27 6:39 ` Heiner Kallweit
2019-05-27 19:12 ` Florian Fainelli
2019-05-27 6:16 ` [PATCH v2 2/4] net: phy: dp83867: increase SGMII autoneg timer duration Max Uvarov
2019-05-27 6:44 ` Heiner Kallweit
2019-05-27 19:16 ` Florian Fainelli
2019-05-27 6:16 ` [PATCH v2 3/4] net: phy: dp83867: do not call config_init twice Max Uvarov
2019-05-27 19:15 ` Florian Fainelli
2019-05-27 6:16 ` Max Uvarov [this message]
2019-05-27 19:15 ` [PATCH v2 4/4] net: phy: dp83867: Set up RGMII TX delay Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527061607.30030-5-muvarov@gmail.com \
--to=muvarov@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).