From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: marvell10g: report if the PHY fails to boot firmware
Date: Tue, 28 May 2019 18:11:39 +0200 [thread overview]
Message-ID: <20190528161139.GQ18059@lunn.ch> (raw)
In-Reply-To: <20190528154238.ifudfslyofk22xoe@shell.armlinux.org.uk>
> One question: are we happy with failing the probe like this, or would it
> be better to allow the probe to suceed?
>
> As has been pointed out in the C45 MII access patch, we need the PHY
> to bind to the network driver for the MII bus to be accessible to
> userspace, so if we're going to have userspace tools to upload the
> firmware, rather than using u-boot, we need the PHY to be present and
> bound to the network interface.
Hi Russell
It is an interesting question. Failing the probe is the simple
solution. If we don't fail the probe, we then need to allow the
attach, but fail all normal operations, with a noisy kernel log. That
probably means adding a new state to the state machine, PHY_BROKEN.
Enter that state if phy_start_aneg() returns an error?
Andrew
next prev parent reply other threads:[~2019-05-28 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 9:34 [PATCH] net: phy: marvell10g: report if the PHY fails to boot firmware Russell King
2019-05-28 14:36 ` Maxime Chevallier
2019-05-28 14:41 ` Andrew Lunn
2019-05-28 15:42 ` Russell King - ARM Linux admin
2019-05-28 16:11 ` Andrew Lunn [this message]
2019-05-28 16:23 ` Russell King - ARM Linux admin
2019-05-29 11:03 ` Russell King - ARM Linux admin
2019-05-30 14:12 ` Andrew Lunn
2019-05-29 21:26 ` David Miller
2019-05-29 22:22 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528161139.GQ18059@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).