From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: marvell10g: report if the PHY fails to boot firmware
Date: Tue, 28 May 2019 16:36:52 +0200 [thread overview]
Message-ID: <20190528163525.534e31a9@bootlin.com> (raw)
In-Reply-To: <E1hVYVG-0005D8-8w@rmk-PC.armlinux.org.uk>
Hello Russell,
On Tue, 28 May 2019 10:34:42 +0100
Russell King <rmk+kernel@armlinux.org.uk> wrote:
>Some boards do not have the PHY firmware programmed in the 3310's flash,
>which leads to the PHY not working as expected. Warn the user when the
>PHY fails to boot the firmware and refuse to initialise.
>
>Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>---
>I think this patch needs testing with the Marvell 88x2110 PHY before
>this can be merged into mainline, but I think it should go into -rc
>and be back-ported to stable trees to avoid user frustration
I've tested this on a 88x2110 and a 88e2010, who both have the same
register at the same location, at are potentially subject to the same
issue.
Tested-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Thanks,
Maxime
next prev parent reply other threads:[~2019-05-28 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 9:34 [PATCH] net: phy: marvell10g: report if the PHY fails to boot firmware Russell King
2019-05-28 14:36 ` Maxime Chevallier [this message]
2019-05-28 14:41 ` Andrew Lunn
2019-05-28 15:42 ` Russell King - ARM Linux admin
2019-05-28 16:11 ` Andrew Lunn
2019-05-28 16:23 ` Russell King - ARM Linux admin
2019-05-29 11:03 ` Russell King - ARM Linux admin
2019-05-30 14:12 ` Andrew Lunn
2019-05-29 21:26 ` David Miller
2019-05-29 22:22 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528163525.534e31a9@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).