From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB14C04AB6 for ; Tue, 28 May 2019 14:37:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECD932075B for ; Tue, 28 May 2019 14:36:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbfE1Og6 (ORCPT ); Tue, 28 May 2019 10:36:58 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:36597 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726371AbfE1Og6 (ORCPT ); Tue, 28 May 2019 10:36:58 -0400 Received: from bootlin.com (aaubervilliers-681-1-27-134.w90-88.abo.wanadoo.fr [90.88.147.134]) (Authenticated sender: maxime.chevallier@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 4155D200013; Tue, 28 May 2019 14:36:50 +0000 (UTC) Date: Tue, 28 May 2019 16:36:52 +0200 From: Maxime Chevallier To: Russell King Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH] net: phy: marvell10g: report if the PHY fails to boot firmware Message-ID: <20190528163525.534e31a9@bootlin.com> In-Reply-To: References: X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello Russell, On Tue, 28 May 2019 10:34:42 +0100 Russell King wrote: >Some boards do not have the PHY firmware programmed in the 3310's flash, >which leads to the PHY not working as expected. Warn the user when the >PHY fails to boot the firmware and refuse to initialise. > >Signed-off-by: Russell King >--- >I think this patch needs testing with the Marvell 88x2110 PHY before >this can be merged into mainline, but I think it should go into -rc >and be back-ported to stable trees to avoid user frustration I've tested this on a 88x2110 and a 88e2010, who both have the same register at the same location, at are potentially subject to the same issue. Tested-by: Maxime Chevallier Thanks, Maxime