* [PATCH net-next] r8169: remove 1000/Half from supported modes
@ 2019-05-28 16:43 Heiner Kallweit
2019-05-28 17:35 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Heiner Kallweit @ 2019-05-28 16:43 UTC (permalink / raw)
To: Realtek linux nic maintainers, David Miller; +Cc: netdev@vger.kernel.org
MAC on the GBit versions supports 1000/Full only, however the PHY
partially claims to support 1000/Half. So let's explicitly remove
this mode.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 61e7eef5e..0239a3de2 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -6397,7 +6397,10 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
if (ret)
return ret;
- if (!tp->supports_gmii)
+ if (tp->supports_gmii)
+ phy_remove_link_mode(phydev,
+ ETHTOOL_LINK_MODE_1000baseT_Half_BIT);
+ else
phy_set_max_speed(phydev, SPEED_100);
phy_support_asym_pause(phydev);
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] r8169: remove 1000/Half from supported modes
2019-05-28 16:43 [PATCH net-next] r8169: remove 1000/Half from supported modes Heiner Kallweit
@ 2019-05-28 17:35 ` Andrew Lunn
2019-05-28 17:40 ` Florian Fainelli
2019-05-30 4:43 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2019-05-28 17:35 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Realtek linux nic maintainers, David Miller,
netdev@vger.kernel.org
On Tue, May 28, 2019 at 06:43:46PM +0200, Heiner Kallweit wrote:
> MAC on the GBit versions supports 1000/Full only, however the PHY
> partially claims to support 1000/Half. So let's explicitly remove
> this mode.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] r8169: remove 1000/Half from supported modes
2019-05-28 16:43 [PATCH net-next] r8169: remove 1000/Half from supported modes Heiner Kallweit
2019-05-28 17:35 ` Andrew Lunn
@ 2019-05-28 17:40 ` Florian Fainelli
2019-05-28 18:02 ` Heiner Kallweit
2019-05-30 4:43 ` David Miller
2 siblings, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2019-05-28 17:40 UTC (permalink / raw)
To: Heiner Kallweit, Realtek linux nic maintainers, David Miller
Cc: netdev@vger.kernel.org
On 5/28/19 9:43 AM, Heiner Kallweit wrote:
> MAC on the GBit versions supports 1000/Full only, however the PHY
> partially claims to support 1000/Half. So let's explicitly remove
> this mode.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Don't you want a Fixes: tag for that?
> ---
> drivers/net/ethernet/realtek/r8169.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 61e7eef5e..0239a3de2 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -6397,7 +6397,10 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
> if (ret)
> return ret;
>
> - if (!tp->supports_gmii)
> + if (tp->supports_gmii)
> + phy_remove_link_mode(phydev,
> + ETHTOOL_LINK_MODE_1000baseT_Half_BIT);
> + else
> phy_set_max_speed(phydev, SPEED_100);
>
> phy_support_asym_pause(phydev);
>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] r8169: remove 1000/Half from supported modes
2019-05-28 17:40 ` Florian Fainelli
@ 2019-05-28 18:02 ` Heiner Kallweit
0 siblings, 0 replies; 5+ messages in thread
From: Heiner Kallweit @ 2019-05-28 18:02 UTC (permalink / raw)
To: Florian Fainelli, Realtek linux nic maintainers, David Miller
Cc: netdev@vger.kernel.org
On 28.05.2019 19:40, Florian Fainelli wrote:
> On 5/28/19 9:43 AM, Heiner Kallweit wrote:
>> MAC on the GBit versions supports 1000/Full only, however the PHY
>> partially claims to support 1000/Half. So let's explicitly remove
>> this mode.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> Don't you want a Fixes: tag for that?
>
I'm not aware of any problem caused by that. And according to what
I've read 1000/Half has been specified but never really been used.
So it should be sufficient to treat this as an improvement.
>> ---
>> drivers/net/ethernet/realtek/r8169.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
>> index 61e7eef5e..0239a3de2 100644
>> --- a/drivers/net/ethernet/realtek/r8169.c
>> +++ b/drivers/net/ethernet/realtek/r8169.c
>> @@ -6397,7 +6397,10 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
>> if (ret)
>> return ret;
>>
>> - if (!tp->supports_gmii)
>> + if (tp->supports_gmii)
>> + phy_remove_link_mode(phydev,
>> + ETHTOOL_LINK_MODE_1000baseT_Half_BIT);
>> + else
>> phy_set_max_speed(phydev, SPEED_100);
>>
>> phy_support_asym_pause(phydev);
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] r8169: remove 1000/Half from supported modes
2019-05-28 16:43 [PATCH net-next] r8169: remove 1000/Half from supported modes Heiner Kallweit
2019-05-28 17:35 ` Andrew Lunn
2019-05-28 17:40 ` Florian Fainelli
@ 2019-05-30 4:43 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2019-05-30 4:43 UTC (permalink / raw)
To: hkallweit1; +Cc: nic_swsd, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Tue, 28 May 2019 18:43:46 +0200
> MAC on the GBit versions supports 1000/Full only, however the PHY
> partially claims to support 1000/Half. So let's explicitly remove
> this mode.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-30 4:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-28 16:43 [PATCH net-next] r8169: remove 1000/Half from supported modes Heiner Kallweit
2019-05-28 17:35 ` Andrew Lunn
2019-05-28 17:40 ` Florian Fainelli
2019-05-28 18:02 ` Heiner Kallweit
2019-05-30 4:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).