From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 050B2C04AB6 for ; Wed, 29 May 2019 00:56:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C12FF21019 for ; Wed, 29 May 2019 00:56:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559091401; bh=zahpLyb90sxtTl65YX1XkB080URziRlD5xQN72eAcrM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1CU8LOcopG6W/zjhJk9lU1sRiqMUx0FYEEK8M1RRN9XGtrAWJ23srpc950hiA/X/d FKbNyn+OMTTJISnjsLJd3GDpJ0xBOrRryApjooNtu4hPKFdhd+xgtc5a1wAFT1gRDU R82MPwAwZUqEU/nmR/pkOz0apae5rgqA1MdzlDeE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725847AbfE2A4k (ORCPT ); Tue, 28 May 2019 20:56:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:39514 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbfE2A4k (ORCPT ); Tue, 28 May 2019 20:56:40 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8099821019; Wed, 29 May 2019 00:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559091399; bh=zahpLyb90sxtTl65YX1XkB080URziRlD5xQN72eAcrM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zkT8M4ouXYa8uIAZjoJR8FOz4v6Yb9VeaNgOcPSAX3wQ0vVYY6dynhQUYC9zLl6u/ XkbhCghOfe6g0Hn+mr4K69Av4kN3WavpyU0mMsiTqQvTbi34b2uF73xKVm35+dTwhn 9jlzF9J6Wbv4v3YMMnf7Nz1bczZh9Bkeqe5d/Pcg= Date: Tue, 28 May 2019 17:56:39 -0700 From: Greg KH To: Christoph Paasch Cc: David Miller , netdev@vger.kernel.org, William Tu Subject: Re: [PATCH v4.14.x] net: erspan: fix use-after-free Message-ID: <20190529005639.GA16732@kroah.com> References: <20190529000113.49334-1-cpaasch@apple.com> <20190529000744.GA12783@kroah.com> <20190529001421.GB49807@MacBook-Pro-64.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190529001421.GB49807@MacBook-Pro-64.local> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, May 28, 2019 at 05:14:21PM -0700, Christoph Paasch wrote: > On 28/05/19 - 17:07:44, Greg KH wrote: > > On Tue, May 28, 2019 at 05:01:13PM -0700, Christoph Paasch wrote: > > > When building the erspan header for either v1 or v2, the eth_hdr() > > > does not point to the right inner packet's eth_hdr, > > > causing kasan report use-after-free and slab-out-of-bouds read. > > > > > > The patch fixes the following syzkaller issues: > > > [1] BUG: KASAN: slab-out-of-bounds in erspan_xmit+0x22d4/0x2430 net/ipv4/ip_gre.c:735 > > > [2] BUG: KASAN: slab-out-of-bounds in erspan_build_header+0x3bf/0x3d0 net/ipv4/ip_gre.c:698 > > > [3] BUG: KASAN: use-after-free in erspan_xmit+0x22d4/0x2430 net/ipv4/ip_gre.c:735 > > > [4] BUG: KASAN: use-after-free in erspan_build_header+0x3bf/0x3d0 net/ipv4/ip_gre.c:698 > > > > > > [2] CPU: 0 PID: 3654 Comm: syzkaller377964 Not tainted 4.15.0-rc9+ #185 > > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > > > Call Trace: > > > __dump_stack lib/dump_stack.c:17 [inline] > > > dump_stack+0x194/0x257 lib/dump_stack.c:53 > > > print_address_description+0x73/0x250 mm/kasan/report.c:252 > > > kasan_report_error mm/kasan/report.c:351 [inline] > > > kasan_report+0x25b/0x340 mm/kasan/report.c:409 > > > __asan_report_load_n_noabort+0xf/0x20 mm/kasan/report.c:440 > > > erspan_build_header+0x3bf/0x3d0 net/ipv4/ip_gre.c:698 > > > erspan_xmit+0x3b8/0x13b0 net/ipv4/ip_gre.c:740 > > > __netdev_start_xmit include/linux/netdevice.h:4042 [inline] > > > netdev_start_xmit include/linux/netdevice.h:4051 [inline] > > > packet_direct_xmit+0x315/0x6b0 net/packet/af_packet.c:266 > > > packet_snd net/packet/af_packet.c:2943 [inline] > > > packet_sendmsg+0x3aed/0x60b0 net/packet/af_packet.c:2968 > > > sock_sendmsg_nosec net/socket.c:638 [inline] > > > sock_sendmsg+0xca/0x110 net/socket.c:648 > > > SYSC_sendto+0x361/0x5c0 net/socket.c:1729 > > > SyS_sendto+0x40/0x50 net/socket.c:1697 > > > do_syscall_32_irqs_on arch/x86/entry/common.c:327 [inline] > > > do_fast_syscall_32+0x3ee/0xf9d arch/x86/entry/common.c:389 > > > entry_SYSENTER_compat+0x54/0x63 arch/x86/entry/entry_64_compat.S:129 > > > RIP: 0023:0xf7fcfc79 > > > RSP: 002b:00000000ffc6976c EFLAGS: 00000286 ORIG_RAX: 0000000000000171 > > > RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 0000000020011000 > > > RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020008000 > > > RBP: 000000000000001c R08: 0000000000000000 R09: 0000000000000000 > > > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > > > R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 > > > > > > Commit b423d13c08a6 ("net: erspan: fix use-after-free") fixed the > > > use-after-free. The root-cause change (commit 84e54fe0a5ea ("gre: > > > introduce native tunnel support for ERSPAN")) made it into 4.14. > > > > > > Thus, the fix needs to be backported to 4.14 as well. > > > > > > Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN") > > > Cc: William Tu > > > Signed-off-by: Christoph Paasch > > > --- > > > > > > Notes: > > > This should *only* go into 4.14. > > > > What is the git commit id of this patch in Linus's tree? > > It is b423d13c08a6 ("net: erspan: fix use-after-free"). > > The cherry-pick to 4.14 does not work though, which is why I sent this patch > here. Not a problem, I just needed the original git commit id :) Now queued up, thanks! greg k-h