From: Richard Cochran <richardcochran@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: f.fainelli@gmail.com, vivien.didelot@gmail.com, andrew@lunn.ch,
davem@davemloft.net, john.stultz@linaro.org, tglx@linutronix.de,
sboyd@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/5] net: dsa: mv88e6xxx: Let taggers specify a can_timestamp function
Date: Tue, 28 May 2019 21:49:12 -0700 [thread overview]
Message-ID: <20190529044912.cyg44rqvdo73oeiu@localhost> (raw)
In-Reply-To: <20190528235627.1315-4-olteanv@gmail.com>
On Wed, May 29, 2019 at 02:56:25AM +0300, Vladimir Oltean wrote:
> The newly introduced function is called on both the RX and TX paths.
NAK on this patch.
> The boolean returned by port_txtstamp should only return false if the
> driver tried to timestamp the skb but failed.
So you say.
> Currently there is some logic in the mv88e6xxx driver that determines
> whether it should timestamp frames or not.
>
> This is wasteful, because if the decision is to not timestamp them, then
> DSA will have cloned an skb and freed it immediately afterwards.
No, it isn't wasteful. Look at the tests in that driver to see why.
> Additionally other drivers (sja1105) may have other hardware criteria
> for timestamping frames on RX, and the default conditions for
> timestamping a frame are too restrictive.
I'm sorry, but we won't change the frame just for one device that has
design issues.
Please put device specific workarounds into its driver.
Thanks,
Richard
next prev parent reply other threads:[~2019-05-29 4:49 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 23:56 [PATCH net-next 0/5] PTP support for the SJA1105 DSA driver Vladimir Oltean
2019-05-28 23:56 ` [PATCH net-next 1/5] timecounter: Add helper for reconstructing partial timestamps Vladimir Oltean
2019-05-29 2:14 ` John Stultz
2019-05-29 4:40 ` Richard Cochran
2019-05-29 20:23 ` Vladimir Oltean
2019-05-28 23:56 ` [PATCH net-next 2/5] net: dsa: sja1105: Add support for the PTP clock Vladimir Oltean
2019-05-28 23:56 ` [PATCH net-next 3/5] net: dsa: mv88e6xxx: Let taggers specify a can_timestamp function Vladimir Oltean
2019-05-29 4:49 ` Richard Cochran [this message]
2019-05-29 20:33 ` Vladimir Oltean
2019-05-30 3:51 ` Richard Cochran
2019-05-30 7:42 ` Vladimir Oltean
2019-05-30 14:23 ` Richard Cochran
2019-05-30 14:40 ` Richard Cochran
2019-05-30 14:47 ` Vladimir Oltean
2019-05-30 15:01 ` Richard Cochran
2019-11-19 11:35 ` Design issue in DSA RX timestamping (Was "Re: [PATCH net-next 3/5] net: dsa: mv88e6xxx: Let taggers specify a can_timestamp function") Vladimir Oltean
2019-11-19 14:03 ` Richard Cochran
2019-05-28 23:56 ` [PATCH net-next 4/5] net: dsa: sja1105: Add support for PTP timestamping Vladimir Oltean
2019-05-28 23:56 ` [PATCH net-next 5/5] net: dsa: sja1105: Increase priority of CPU-trapped frames Vladimir Oltean
2019-05-29 4:52 ` [PATCH net-next 0/5] PTP support for the SJA1105 DSA driver Richard Cochran
2019-05-29 20:41 ` Vladimir Oltean
2019-05-30 3:45 ` Richard Cochran
2019-05-30 9:01 ` Vladimir Oltean
2019-05-30 14:30 ` Richard Cochran
2019-05-30 14:57 ` Vladimir Oltean
2019-05-30 15:05 ` Richard Cochran
2019-05-30 15:23 ` Vladimir Oltean
2019-05-31 4:34 ` Richard Cochran
2019-05-31 13:23 ` Vladimir Oltean
2019-05-31 14:08 ` Richard Cochran
2019-05-31 14:27 ` Vladimir Oltean
2019-05-31 15:11 ` Richard Cochran
2019-05-31 15:21 ` Richard Cochran
2019-05-31 15:23 ` Vladimir Oltean
2019-05-31 16:09 ` Richard Cochran
2019-05-31 16:16 ` Vladimir Oltean
2019-05-31 18:12 ` Vladimir Oltean
2019-06-01 5:07 ` Richard Cochran
2019-06-01 10:31 ` Vladimir Oltean
2019-06-01 12:06 ` Vladimir Oltean
2019-06-02 2:18 ` Richard Cochran
2019-06-02 2:17 ` Richard Cochran
2019-06-01 5:03 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529044912.cyg44rqvdo73oeiu@localhost \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).