From: Ido Schimmel <idosch@idosch.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com,
jakub.kicinski@netronome.com, sthemmin@microsoft.com,
dsahern@gmail.com, saeedm@mellanox.com, leon@kernel.org,
f.fainelli@gmail.com
Subject: Re: [patch net-next v2 5/7] mlxfw: Introduce status_notify op and call it to notify about the status
Date: Wed, 29 May 2019 09:10:20 +0300 [thread overview]
Message-ID: <20190529061020.GD10684@splinter> (raw)
In-Reply-To: <20190528114846.1983-6-jiri@resnulli.us>
On Tue, May 28, 2019 at 01:48:44PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> Add new op status_notify which is called to update the user about
> flashing status.
>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
As I wrote during internal review, I think it is weird to have drivers
implement this status_notify() operation given mlxfw has all the
required information. The only thing drivers are doing is resolving the
devlink instance and calling into devlink. Would have been cleaner to
pass the devlink instance to mlxfw and have it call into devlink for
status updates directly.
But I don't see anything incorrect, so:
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
next prev parent reply other threads:[~2019-05-29 6:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 11:48 [patch net-next v2 0/7] expose flash update status to user Jiri Pirko
2019-05-28 11:48 ` [patch net-next v2 1/7] mlxsw: Move firmware flash implementation to devlink Jiri Pirko
2019-05-29 6:03 ` Ido Schimmel
2019-05-28 11:48 ` [patch net-next v2 2/7] mlx5: " Jiri Pirko
2019-05-28 11:48 ` [patch net-next v2 3/7] mlxfw: Propagate error messages through extack Jiri Pirko
2019-05-29 6:03 ` Ido Schimmel
2019-05-28 11:48 ` [patch net-next v2 4/7] devlink: allow driver to update progress of flash update Jiri Pirko
2019-05-28 19:55 ` Jakub Kicinski
2019-05-29 6:04 ` Ido Schimmel
2019-05-28 11:48 ` [patch net-next v2 5/7] mlxfw: Introduce status_notify op and call it to notify about the status Jiri Pirko
2019-05-29 6:10 ` Ido Schimmel [this message]
2019-05-28 11:48 ` [patch net-next v2 6/7] mlxsw: Implement flash update status notifications Jiri Pirko
2019-05-29 6:12 ` Ido Schimmel
2019-05-28 11:48 ` [patch net-next v2 7/7] netdevsim: implement fake flash updating with notifications Jiri Pirko
2019-05-28 20:01 ` Jakub Kicinski
2019-05-29 8:00 ` Jiri Pirko
2019-05-29 16:47 ` Jakub Kicinski
2019-05-29 19:30 ` Jiri Pirko
2019-05-28 11:50 ` [patch net-next v2 1/3] header update Jiri Pirko
2019-05-28 11:50 ` [patch net-next v2 2/3] devlink: implement flash update status monitoring Jiri Pirko
2019-05-28 11:50 ` [patch net-next v2 3/3] devlink: implement flash " Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529061020.GD10684@splinter \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).