From: Michal Rostecki <mrostecki@opensuse.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Michal Rostecki <mrostecki@opensuse.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf] libbpf: Return btf_fd in libbpf__probe_raw_btf
Date: Wed, 29 May 2019 12:59:59 +0000 [thread overview]
Message-ID: <20190529125959.GA31842@wotan.suse.de> (raw)
In-Reply-To: <e28170e1-cf06-87ef-812b-9b9e6185d925@cogentembedded.com>
On Wed, May 29, 2019 at 12:53:42PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 29.05.2019 11:29, Michal Rostecki wrote:
>
> > Function load_sk_storage_btf expects that libbpf__probe_raw_btf is
> > returning a btf descriptor, but before this change it was returning
> > an information about whether the probe was successful (0 or 1).
> > load_sk_storage_btf was using that value as an argument to the close
> > function, which was resulting in closing stdout and thus terminating the
> > process which used that dunction.
>
> Function? :-)
Opps! I will fix in v2. Thanks!
next prev parent reply other threads:[~2019-05-29 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 8:29 [PATCH bpf] libbpf: Return btf_fd in libbpf__probe_raw_btf Michal Rostecki
2019-05-29 9:53 ` Sergei Shtylyov
2019-05-29 12:59 ` Michal Rostecki [this message]
2019-05-29 15:35 ` Andrii Nakryiko
2019-05-29 15:48 ` Michal Rostecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529125959.GA31842@wotan.suse.de \
--to=mrostecki@opensuse.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).