From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0286C28CC0 for ; Wed, 29 May 2019 23:03:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DCEE242E8 for ; Wed, 29 May 2019 23:03:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="iz5I6M7+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbfE2XDm (ORCPT ); Wed, 29 May 2019 19:03:42 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40284 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbfE2XDm (ORCPT ); Wed, 29 May 2019 19:03:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=g3dIPaHOm9Yirjunzdr4EeMbY8yeAgg4qL2WO6u+NKc=; b=iz5I6M7+gVI+X8TxAY6IUt4tuC ATumOgL3/y+VeeZx/8MuZRLlHxXe+vo3WjcGnHF43bZINAthYmqAqhmubZj9CkCTvu00NVXneJGu2 wh/vzFhKWZidt2F9jHJk7ZX+KoLI4boppsXR68OAbzAFNv9tILi4GOKpEQFuhVedyIFA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hW7bY-0002wo-GM; Thu, 30 May 2019 01:03:32 +0200 Date: Thu, 30 May 2019 01:03:32 +0200 From: Andrew Lunn To: Ioana Ciornei Cc: Russell King - ARM Linux admin , "f.fainelli@gmail.com" , "hkallweit1@gmail.com" , "maxime.chevallier@bootlin.com" , "olteanv@gmail.com" , "thomas.petazzoni@bootlin.com" , "davem@davemloft.net" , "vivien.didelot@gmail.com" , "netdev@vger.kernel.org" , "lkp@01.org" , kernel test robot Subject: Re: [net] 9dd6d07682: kernel_BUG_at_drivers/net/phy/mdio_bus.c Message-ID: <20190529230332.GC18059@lunn.ch> References: <1558992127-26008-11-git-send-email-ioana.ciornei@nxp.com> <20190529023557.GA22325@shao2-debian> <20190529162527.kuunt5gxif6wvhoo@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > phydev = dsa_port_get_phy_device(dp); > if (!phydev) > return 0; > > I don't see how this method is sane either. If i remember correctly, the thinking was, you can get away without the PHY, at least during bring up of a new switch/board. So don't consider this a fatal error. Now that it is fatal, in the sense of an Opps, maybe we should change this. Andrew