From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A467C28CC0 for ; Thu, 30 May 2019 18:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58B73246C2 for ; Thu, 30 May 2019 18:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726574AbfE3S51 (ORCPT ); Thu, 30 May 2019 14:57:27 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57644 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbfE3S51 (ORCPT ); Thu, 30 May 2019 14:57:27 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EF1B014D9FA44; Thu, 30 May 2019 11:57:26 -0700 (PDT) Date: Thu, 30 May 2019 11:57:26 -0700 (PDT) Message-Id: <20190530.115726.2295852303789730642.davem@davemloft.net> To: dsahern@gmail.com Cc: alexei.starovoitov@gmail.com, dsahern@kernel.org, netdev@vger.kernel.org, idosch@mellanox.com, saeedm@mellanox.com, kafai@fb.com, weiwan@google.com Subject: Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info From: David Miller In-Reply-To: <65320e39-8ea2-29d8-b5f9-2de0c0c7e689@gmail.com> References: <20190530.110149.956896317988019526.davem@davemloft.net> <65320e39-8ea2-29d8-b5f9-2de0c0c7e689@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 May 2019 11:57:27 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern Date: Thu, 30 May 2019 12:52:43 -0600 > The nexthop code paths are not live yet. More changes are needed before > that can happen. I have been sending the patches in small, reviewable > increments to be kind to reviewers than a single 27 patch set with > everything (the remaining set which is over the limit BTW). We definitely need tests using the new netlink attributes even if the code paths aren't live yet.