From: Gen Zhang <blackgod016574@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: paul@paul-moore.com, sds@tycho.nsa.gov, eparis@parisplace.org,
ccross@android.com, selinux@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] hooks: fix a missing-check bug in selinux_add_mnt_opt()
Date: Thu, 30 May 2019 17:24:26 +0800 [thread overview]
Message-ID: <20190530092426.GA3666@zhanggen-UX430UQ> (raw)
In-Reply-To: <236195a3-b607-5cf6-ac60-8c5ea2e95b41@cogentembedded.com>
On Thu, May 30, 2019 at 12:22:15PM +0300, Sergei Shtylyov wrote:
> On 30.05.2019 12:18, Gen Zhang wrote:
>
> >>On 30.05.2019 11:06, Gen Zhang wrote:
> >>
> >>>In selinux_add_mnt_opt(), 'val' is allcoted by kmemdup_nul(). It returns
> >>
> >> Allocated?
>
> >Thanks for your reply, Sergei. I used 'allocated' because kmemdup_nul()
> >does some allocation in its implementation. And its docs descrips:
>
> Describes?
>
> >"Return: newly allocated copy of @s with NUL-termination or %NULL in
> >case of error". I think it is proper to use 'allocated' here. But it
> >could be 'assigned', which is better, right?
>
> I was only trying to point out the typos in this word. :-)
>
> >Thanks
> >Gen
> >>
> >>>NULL when fails. So 'val' should be checked.
> >>>
> >>>Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
> >>[...]
>
> MBR, Sergei
Well, my mistake. Thanks for your comments, Sergei!
Thanks
Gen
prev parent reply other threads:[~2019-05-30 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 8:06 [PATCH] hooks: fix a missing-check bug in selinux_add_mnt_opt() Gen Zhang
2019-05-30 8:30 ` Ondrej Mosnacek
2019-05-30 8:54 ` [PATCH v2] " Gen Zhang
2019-05-31 15:55 ` Paul Moore
2019-06-01 1:54 ` Gen Zhang
2019-05-30 9:11 ` [PATCH] " Sergei Shtylyov
2019-05-30 9:18 ` Gen Zhang
2019-05-30 9:22 ` Sergei Shtylyov
2019-05-30 9:24 ` Gen Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530092426.GA3666@zhanggen-UX430UQ \
--to=blackgod016574@gmail.com \
--cc=ccross@android.com \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox