From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH iproute2] bridge: mdb: restore text output format
Date: Thu, 30 May 2019 11:06:16 -0700 [thread overview]
Message-ID: <20190530110616.48097b66@hermes.lan> (raw)
In-Reply-To: <20190529175242.20919-1-nikolay@cumulusnetworks.com>
On Wed, 29 May 2019 20:52:42 +0300
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> While I fixed the mdb json output, I did overlook the text output.
> This patch returns the original text output format:
> dev <bridge> port <port> grp <mcast group> <temp|permanent> <flags> <timer>
> Example (old format, restored by this patch):
> dev br0 port eth8 grp 239.1.1.11 temp
>
> Example (changed format after the commit below):
> 23: br0 eth8 239.1.1.11 temp
>
> We had some reports of failing scripts which were parsing the output.
> Also the old format matches the bridge mdb command syntax which makes
> it easier to build commands out of the output.
>
> Fixes: c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Looks good, thanks for fixing.
Applied.
prev parent reply other threads:[~2019-05-30 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 17:52 [PATCH iproute2] bridge: mdb: restore text output format Nikolay Aleksandrov
2019-05-30 18:06 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530110616.48097b66@hermes.lan \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).