From: Stephen Hemminger <stephen@networkplumber.org>
To: Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH iproute2-next 1/1] tc: add support for act ctinfo
Date: Thu, 30 May 2019 12:59:04 -0700 [thread overview]
Message-ID: <20190530125904.713e72b1@hermes.lan> (raw)
In-Reply-To: <20190530164246.17955-2-ldir@darbyshire-bryant.me.uk>
On Thu, 30 May 2019 16:43:20 +0000
Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk> wrote:
Please don't use HTML encoded mail. I.e not exchange.
> +
> + if (argc) {
> + if (matches(*argv, "dscp") == 0) {
> + NEXT_ARG();
> + char *slash;
> + if ((slash = strchr(*argv, '/')))
> + *slash = '\0';
Don't mix assignment and conditional on same line
next prev parent reply other threads:[~2019-05-30 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 16:43 [RFC PATCH iproute2-next 0/1] tc: add support for act ctinfo Kevin 'ldir' Darbyshire-Bryant
2019-05-30 16:43 ` [RFC PATCH iproute2-next 1/1] " Kevin 'ldir' Darbyshire-Bryant
2019-05-30 17:32 ` Stephen Hemminger
2019-05-30 17:46 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-30 17:38 ` Stephen Hemminger
2019-05-30 19:59 ` Stephen Hemminger [this message]
2019-05-31 8:29 ` Kevin 'ldir' Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530125904.713e72b1@hermes.lan \
--to=stephen@networkplumber.org \
--cc=ldir@darbyshire-bryant.me.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).