netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [net-next:master 251/280] net/ipv4/tcp_fastopen.c:75:29: sparse: sparse: symbol 'tcp_fastopen_alloc_ctx' was not declared. Should it be static?
@ 2019-05-30 23:06 kbuild test robot
  2019-05-30 23:06 ` [RFC PATCH net-next] tcp: tcp_fastopen_alloc_ctx() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-05-30 23:06 UTC (permalink / raw)
  To: Jason Baron
  Cc: kbuild-all, netdev, Christoph Paasch, Eric Dumazet,
	Alexey Kuznetsov, Hideaki YOSHIFUJI, linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   84a32edec48056131c91bebb706c2a0a5976a1a1
commit: 9092a76d3cf8638467b09bbb4f409094349b2b53 [251/280] tcp: add backup TFO key infrastructure
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
        git checkout 9092a76d3cf8638467b09bbb4f409094349b2b53
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> net/ipv4/tcp_fastopen.c:75:29: sparse: sparse: symbol 'tcp_fastopen_alloc_ctx' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH net-next] tcp: tcp_fastopen_alloc_ctx() can be static
  2019-05-30 23:06 [net-next:master 251/280] net/ipv4/tcp_fastopen.c:75:29: sparse: sparse: symbol 'tcp_fastopen_alloc_ctx' was not declared. Should it be static? kbuild test robot
@ 2019-05-30 23:06 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-05-30 23:06 UTC (permalink / raw)
  To: Jason Baron
  Cc: kbuild-all, netdev, Christoph Paasch, Eric Dumazet,
	Alexey Kuznetsov, Hideaki YOSHIFUJI, linux-kernel


Fixes: 9092a76d3cf8 ("tcp: add backup TFO key infrastructure")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 tcp_fastopen.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/ipv4/tcp_fastopen.c b/net/ipv4/tcp_fastopen.c
index 8e15804..7d19fa4 100644
--- a/net/ipv4/tcp_fastopen.c
+++ b/net/ipv4/tcp_fastopen.c
@@ -72,9 +72,9 @@ void tcp_fastopen_ctx_destroy(struct net *net)
 		call_rcu(&ctxt->rcu, tcp_fastopen_ctx_free);
 }
 
-struct tcp_fastopen_context *tcp_fastopen_alloc_ctx(void *primary_key,
-						    void *backup_key,
-						    unsigned int len)
+static struct tcp_fastopen_context *tcp_fastopen_alloc_ctx(void *primary_key,
+							   void *backup_key,
+							   unsigned int len)
 {
 	struct tcp_fastopen_context *new_ctx;
 	void *key = primary_key;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-30 23:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-30 23:06 [net-next:master 251/280] net/ipv4/tcp_fastopen.c:75:29: sparse: sparse: symbol 'tcp_fastopen_alloc_ctx' was not declared. Should it be static? kbuild test robot
2019-05-30 23:06 ` [RFC PATCH net-next] tcp: tcp_fastopen_alloc_ctx() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).