From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4EDC04AB6 for ; Fri, 31 May 2019 21:26:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30ED424740 for ; Fri, 31 May 2019 21:26:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727316AbfEaV0R (ORCPT ); Fri, 31 May 2019 17:26:17 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50768 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbfEaV0Q (ORCPT ); Fri, 31 May 2019 17:26:16 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1B10B1500FF42; Fri, 31 May 2019 14:26:16 -0700 (PDT) Date: Fri, 31 May 2019 14:26:15 -0700 (PDT) Message-Id: <20190531.142615.403782868688096350.davem@davemloft.net> To: phil@nwl.cc Cc: netdev@vger.kernel.org, dsahern@gmail.com Subject: Re: [net-next PATCH] net: rtnetlink: Enslave device before bringing it up From: David Miller In-Reply-To: <20190529135120.32241-1-phil@nwl.cc> References: <20190529135120.32241-1-phil@nwl.cc> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 31 May 2019 14:26:16 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Phil Sutter Date: Wed, 29 May 2019 15:51:20 +0200 > Unlike with bridges, one can't add an interface to a bond and set it up > at the same time: > > | # ip link set dummy0 down > | # ip link set dummy0 master bond0 up > | Error: Device can not be enslaved while up. > > Of all drivers with ndo_add_slave callback, bond and team decline if > IFF_UP flag is set, vrf cycles the interface (i.e., sets it down and > immediately up again) and the others just don't care. > > Support the common notion of setting the interface up after enslaving it > by sorting the operations accordingly. > > Signed-off-by: Phil Sutter What about other flags like IFF_PROMISCUITY?