From: Andrew Lunn <andrew@lunn.ch>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, linville@redhat.com
Subject: Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes
Date: Fri, 31 May 2019 13:59:28 +0200 [thread overview]
Message-ID: <20190531115928.GA18608@lunn.ch> (raw)
In-Reply-To: <20190531093029.GD15954@unicorn.suse.cz>
> > @@ -634,10 +636,14 @@ static void dump_link_caps(const char *prefix, const char *an_prefix,
> > "100baseT/Half" },
> > { 1, ETHTOOL_LINK_MODE_100baseT_Full_BIT,
> > "100baseT/Full" },
> > + { 1, ETHTOOL_LINK_MODE_100baseT1_Full_BIT,
> > + "100baseT1/Full" },
> > { 0, ETHTOOL_LINK_MODE_1000baseT_Half_BIT,
> > "1000baseT/Half" },
> > { 1, ETHTOOL_LINK_MODE_1000baseT_Full_BIT,
> > "1000baseT/Full" },
> > + { 1, ETHTOOL_LINK_MODE_1000baseT1_Full_BIT,
> > + "1000baseT1/Full" },
> > { 0, ETHTOOL_LINK_MODE_1000baseKX_Full_BIT,
> > "1000baseKX/Full" },
> > { 0, ETHTOOL_LINK_MODE_2500baseX_Full_BIT,
>
> Does it mean that we could end up with lines like
>
> 100baseT/Half 100baseT/Full 100baseT1/Full
> 1000baseT/Full 1000baseT1/Full
>
> if there is a NIC supporting both T and T1?
Hi Michal
In theory, it is possible for a PHY to support both plain T and
T1. And a 1000BaseT could also implement 1000BaseT2 and 1000BaseT1.
I've not yet seen an actual PHY which does this though.
> It would
> be probably confusing for users as modes on the same line always were
> half/full duplex variants of the same.
I can clear the same_line flag.
> You should also add the new modes to ethtool.8.in.
Yes, will do.
Andrew
next prev parent reply other threads:[~2019-05-31 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 18:06 [PATCH 0/2] Add 100BaseT1 and 1000BaseT1 Andrew Lunn
2019-05-30 18:06 ` [PATCH 1/2] ethtool: sync ethtool-copy.h with linux-next from 30/05/2019 Andrew Lunn
2019-05-30 18:06 ` [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes Andrew Lunn
2019-05-31 9:30 ` Michal Kubecek
2019-05-31 11:59 ` Andrew Lunn [this message]
2019-05-31 12:21 ` Lucas Stach
2019-05-31 12:30 ` Andrew Lunn
2019-05-31 13:04 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531115928.GA18608@lunn.ch \
--to=andrew@lunn.ch \
--cc=linville@redhat.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).