From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29FBCC04AB6 for ; Fri, 31 May 2019 11:59:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E75A426885 for ; Fri, 31 May 2019 11:59:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="kmFKQgn4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727114AbfEaL7b (ORCPT ); Fri, 31 May 2019 07:59:31 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:44372 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726442AbfEaL7a (ORCPT ); Fri, 31 May 2019 07:59:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=N+YQAv+JDAfDBNAmFyjywDkye+Ulq8gkff+04qV3ZBo=; b=kmFKQgn4IzJN7DrfpYJbKY/HOY J3NcU7rn35RjmwZEi6fOXoFhNr/JOnClM3KWnTreTTPUgrIdxIqsx7EeT/HjK+jz8Bc2MZh3vuMVr RKfQtv+JwHhtwq75gqYb9p0W/Ypn9+0LlWqJ3xWFbiZreH6m9/rR6z1WmNqjDLTDArN8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hWgC0-0004uh-Dc; Fri, 31 May 2019 13:59:28 +0200 Date: Fri, 31 May 2019 13:59:28 +0200 From: Andrew Lunn To: Michal Kubecek Cc: netdev@vger.kernel.org, linville@redhat.com Subject: Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes Message-ID: <20190531115928.GA18608@lunn.ch> References: <20190530180616.1418-1-andrew@lunn.ch> <20190530180616.1418-3-andrew@lunn.ch> <20190531093029.GD15954@unicorn.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190531093029.GD15954@unicorn.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > @@ -634,10 +636,14 @@ static void dump_link_caps(const char *prefix, const char *an_prefix, > > "100baseT/Half" }, > > { 1, ETHTOOL_LINK_MODE_100baseT_Full_BIT, > > "100baseT/Full" }, > > + { 1, ETHTOOL_LINK_MODE_100baseT1_Full_BIT, > > + "100baseT1/Full" }, > > { 0, ETHTOOL_LINK_MODE_1000baseT_Half_BIT, > > "1000baseT/Half" }, > > { 1, ETHTOOL_LINK_MODE_1000baseT_Full_BIT, > > "1000baseT/Full" }, > > + { 1, ETHTOOL_LINK_MODE_1000baseT1_Full_BIT, > > + "1000baseT1/Full" }, > > { 0, ETHTOOL_LINK_MODE_1000baseKX_Full_BIT, > > "1000baseKX/Full" }, > > { 0, ETHTOOL_LINK_MODE_2500baseX_Full_BIT, > > Does it mean that we could end up with lines like > > 100baseT/Half 100baseT/Full 100baseT1/Full > 1000baseT/Full 1000baseT1/Full > > if there is a NIC supporting both T and T1? Hi Michal In theory, it is possible for a PHY to support both plain T and T1. And a 1000BaseT could also implement 1000BaseT2 and 1000BaseT1. I've not yet seen an actual PHY which does this though. > It would > be probably confusing for users as modes on the same line always were > half/full duplex variants of the same. I can clear the same_line flag. > You should also add the new modes to ethtool.8.in. Yes, will do. Andrew