netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: f.fainelli@gmail.com, vivien.didelot@gmail.com, andrew@lunn.ch,
	davem@davemloft.net, richardcochran@gmail.com,
	john.stultz@linaro.org, tglx@linutronix.de, sboyd@kernel.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Vladimir Oltean <olteanv@gmail.com>
Subject: [PATCH v2 net-next 08/10] net: dsa: sja1105: Make sja1105_is_link_local not match meta frames
Date: Mon,  3 Jun 2019 00:39:24 +0300	[thread overview]
Message-ID: <20190602213926.2290-9-olteanv@gmail.com> (raw)
In-Reply-To: <20190602213926.2290-1-olteanv@gmail.com>

Although meta frames are configured to be sent at SJA1105_META_DMAC
(01-80-C2-00-00-0E) which is a multicast MAC address that would also be
trapped by the switch to the CPU, were it to receive it on a front-panel
port, meta frames are conceptually not link-local frames, they only
carry their RX timestamps.

The choice of sending meta frames at a multicast DMAC is a pragmatic
one, to avoid installing an extra entry to the DSA master port's
multicast MAC filter.

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
---
Changes in v2:

Patch is new.

 include/linux/dsa/sja1105.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/dsa/sja1105.h b/include/linux/dsa/sja1105.h
index f3237afed35a..d64e56d6c521 100644
--- a/include/linux/dsa/sja1105.h
+++ b/include/linux/dsa/sja1105.h
@@ -31,6 +31,8 @@ static inline bool sja1105_is_link_local(const struct sk_buff *skb)
 	const struct ethhdr *hdr = eth_hdr(skb);
 	u64 dmac = ether_addr_to_u64(hdr->h_dest);
 
+	if (ntohs(hdr->h_proto) == ETH_P_SJA1105_META)
+		return false;
 	if ((dmac & SJA1105_LINKLOCAL_FILTER_A_MASK) ==
 		    SJA1105_LINKLOCAL_FILTER_A)
 		return true;
-- 
2.17.1


  parent reply	other threads:[~2019-06-02 21:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02 21:39 [PATCH v2 net-next 00/10] PTP support for the SJA1105 DSA driver Vladimir Oltean
2019-06-02 21:39 ` [PATCH v2 net-next 01/10] net: dsa: Keep a pointer to the skb clone for TX timestamping Vladimir Oltean
2019-06-02 21:39 ` [PATCH v2 net-next 02/10] net: dsa: Add teardown callback for drivers Vladimir Oltean
2019-06-03  1:07   ` Andrew Lunn
2019-06-03 10:02     ` Vladimir Oltean
2019-06-02 21:39 ` [PATCH v2 net-next 03/10] net: dsa: tag_8021q: Create helper function for removing VLAN header Vladimir Oltean
2019-06-02 21:39 ` [PATCH v2 net-next 04/10] net: dsa: sja1105: Move sja1105_change_tpid into sja1105_vlan_filtering Vladimir Oltean
2019-06-02 21:39 ` [PATCH v2 net-next 05/10] net: dsa: sja1105: Limit use of incl_srcpt to bridge+vlan mode Vladimir Oltean
2019-06-02 21:39 ` [PATCH v2 net-next 06/10] net: dsa: sja1105: Add support for the PTP clock Vladimir Oltean
2019-06-02 21:39 ` [PATCH v2 net-next 07/10] net: dsa: sja1105: Move sja1105_is_link_local to include/linux Vladimir Oltean
2019-06-02 21:39 ` Vladimir Oltean [this message]
2019-06-02 22:00   ` [PATCH v2 net-next 08/10] net: dsa: sja1105: Make sja1105_is_link_local not match meta frames Vladimir Oltean
2019-06-02 21:39 ` [PATCH v2 net-next 09/10] net: dsa: sja1105: Add support for PTP timestamping Vladimir Oltean
2019-06-02 21:39 ` [PATCH v2 net-next 10/10] net: dsa: sja1105: Increase priority of CPU-trapped frames Vladimir Oltean
2019-06-03 23:13 ` [PATCH v2 net-next 00/10] PTP support for the SJA1105 DSA driver Vladimir Oltean
2019-06-03 23:19   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190602213926.2290-9-olteanv@gmail.com \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).