From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA4EC04AB5 for ; Mon, 3 Jun 2019 21:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B74726D2C for ; Mon, 3 Jun 2019 21:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726535AbfFCV7Z (ORCPT ); Mon, 3 Jun 2019 17:59:25 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35934 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726173AbfFCV7Z (ORCPT ); Mon, 3 Jun 2019 17:59:25 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EF10C133E97D9; Mon, 3 Jun 2019 14:59:24 -0700 (PDT) Date: Mon, 03 Jun 2019 14:59:24 -0700 (PDT) Message-Id: <20190603.145924.1916623136571096714.davem@davemloft.net> To: edumazet@google.com Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH net-next] ipv6: icmp: use this_cpu_read() in icmpv6_sk() From: David Miller In-Reply-To: <20190531222700.252607-1-edumazet@google.com> References: <20190531222700.252607-1-edumazet@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Jun 2019 14:59:25 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet Date: Fri, 31 May 2019 15:27:00 -0700 > In general, this_cpu_read(*X) is faster than *this_cpu_ptr(X) > > Also remove the inline attibute, totally useless. > > Signed-off-by: Eric Dumazet > Cc: Kefeng Wang Applied.