* [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK
@ 2019-06-01 8:06 YueHaibing
2019-06-02 7:50 ` Michal Kalderon
2019-06-03 22:11 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-06-01 8:06 UTC (permalink / raw)
To: davem, gregkh, tglx, ariel.elior, michal.kalderon
Cc: linux-kernel, netdev, YueHaibing
Fix gcc build error while CONFIG_DEVLINK is not set
drivers/net/ethernet/qlogic/qed/qed_main.o: In function `qed_remove':
qed_main.c:(.text+0x1eb4): undefined reference to `devlink_unregister'
Select DEVLINK to fix this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 24e04879abdd ("qed: Add qed devlink parameters table")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/qlogic/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/Kconfig b/drivers/net/ethernet/qlogic/Kconfig
index fdbb3ce..a391cf6 100644
--- a/drivers/net/ethernet/qlogic/Kconfig
+++ b/drivers/net/ethernet/qlogic/Kconfig
@@ -87,6 +87,7 @@ config QED
depends on PCI
select ZLIB_INFLATE
select CRC8
+ select NET_DEVLINK
---help---
This enables the support for ...
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK
2019-06-01 8:06 [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK YueHaibing
@ 2019-06-02 7:50 ` Michal Kalderon
2019-06-03 22:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Michal Kalderon @ 2019-06-02 7:50 UTC (permalink / raw)
To: YueHaibing, davem@davemloft.net, gregkh@linuxfoundation.org,
tglx@linutronix.de, Ariel Elior
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org>
> On Behalf Of YueHaibing
>
> Fix gcc build error while CONFIG_DEVLINK is not set
>
> drivers/net/ethernet/qlogic/qed/qed_main.o: In function `qed_remove':
> qed_main.c:(.text+0x1eb4): undefined reference to `devlink_unregister'
>
> Select DEVLINK to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 24e04879abdd ("qed: Add qed devlink parameters table")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/qlogic/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/qlogic/Kconfig
> b/drivers/net/ethernet/qlogic/Kconfig
> index fdbb3ce..a391cf6 100644
> --- a/drivers/net/ethernet/qlogic/Kconfig
> +++ b/drivers/net/ethernet/qlogic/Kconfig
> @@ -87,6 +87,7 @@ config QED
> depends on PCI
> select ZLIB_INFLATE
> select CRC8
> + select NET_DEVLINK
> ---help---
> This enables the support for ...
>
> --
> 2.7.4
>
Thanks,
Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK
2019-06-01 8:06 [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK YueHaibing
2019-06-02 7:50 ` Michal Kalderon
@ 2019-06-03 22:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-06-03 22:11 UTC (permalink / raw)
To: yuehaibing
Cc: gregkh, tglx, ariel.elior, michal.kalderon, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Sat, 1 Jun 2019 16:06:05 +0800
> Fix gcc build error while CONFIG_DEVLINK is not set
>
> drivers/net/ethernet/qlogic/qed/qed_main.o: In function `qed_remove':
> qed_main.c:(.text+0x1eb4): undefined reference to `devlink_unregister'
>
> Select DEVLINK to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 24e04879abdd ("qed: Add qed devlink parameters table")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-03 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-01 8:06 [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK YueHaibing
2019-06-02 7:50 ` Michal Kalderon
2019-06-03 22:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).