From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next] net: fix use-after-free in kfree_skb_list
Date: Mon, 3 Jun 2019 11:07:27 +0200 [thread overview]
Message-ID: <20190603090727.g2cxedtuwe2hhvjl@salvia> (raw)
In-Reply-To: <20190602182418.117629-1-edumazet@google.com>
On Sun, Jun 02, 2019 at 11:24:18AM -0700, Eric Dumazet wrote:
> syzbot reported nasty use-after-free [1]
>
> Lets remove frag_list field from structs ip_fraglist_iter
> and ip6_fraglist_iter. This seens not needed anyway.
>
> [1] :
> BUG: KASAN: use-after-free in kfree_skb_list+0x5d/0x60 net/core/skbuff.c:706
> Read of size 8 at addr ffff888085a3cbc0 by task syz-executor303/8947
[...]
>
> Memory state around the buggy address:
> ffff888085a3ca80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> ffff888085a3cb00: 00 00 00 00 00 00 00 00 00 00 00 00 fc fc fc fc
> >ffff888085a3cb80: fc fc fc fc fc fc fc fc fb fb fb fb fb fb fb fb
> ^
> ffff888085a3cc00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
> ffff888085a3cc80: fb fb fb fb fc fc fc fc fc fc fc fc fc fc fc fc
>
> Fixes: 0feca6190f88 ("net: ipv6: add skbuff fraglist splitter")
> Fixes: c8b17be0b7a4 ("net: ipv4: add skbuff fraglist splitter")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Thanks!
next prev parent reply other threads:[~2019-06-03 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 18:24 [PATCH net-next] net: fix use-after-free in kfree_skb_list Eric Dumazet
2019-06-03 9:07 ` Pablo Neira Ayuso [this message]
2019-06-03 22:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603090727.g2cxedtuwe2hhvjl@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox