From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org,
syzbot+bad6e32808a3a97b1515@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next] net: ipv4: fix rcu lockdep splat due to wrong annotation
Date: Tue, 04 Jun 2019 14:24:36 -0700 (PDT) [thread overview]
Message-ID: <20190604.142436.1951250822599766015.davem@davemloft.net> (raw)
In-Reply-To: <20190603204144.28320-1-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Mon, 3 Jun 2019 22:41:44 +0200
> syzbot triggered following splat when strict netlink
> validation is enabled:
>
> net/ipv4/devinet.c:1766 suspicious rcu_dereference_check() usage!
>
> This occurs because we hold RTNL mutex, but no rcu read lock.
> The second call site holds both, so just switch to the _rtnl variant.
>
> Reported-by: syzbot+bad6e32808a3a97b1515@syzkaller.appspotmail.com
> Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied.
prev parent reply other threads:[~2019-06-04 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 18:51 WARNING: suspicious RCU usage in in_dev_dump_addr syzbot
2019-06-03 20:41 ` [PATCH net-next] net: ipv4: fix rcu lockdep splat due to wrong annotation Florian Westphal
2019-06-04 21:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604.142436.1951250822599766015.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=syzbot+bad6e32808a3a97b1515@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).