From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5010C282CE for ; Tue, 4 Jun 2019 21:55:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3ED32070B for ; Tue, 4 Jun 2019 21:55:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726460AbfFDVzX (ORCPT ); Tue, 4 Jun 2019 17:55:23 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53052 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726373AbfFDVzX (ORCPT ); Tue, 4 Jun 2019 17:55:23 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AD94615024F2C; Tue, 4 Jun 2019 14:55:22 -0700 (PDT) Date: Tue, 04 Jun 2019 14:55:22 -0700 (PDT) Message-Id: <20190604.145522.1019698960837846036.davem@davemloft.net> To: dsahern@kernel.org Cc: netdev@vger.kernel.org, dsahern@gmail.com Subject: Re: [PATCH net-next] ipv6: Always allocate pcpu memory in a fib6_nh From: David Miller In-Reply-To: <20190604013703.2043-1-dsahern@kernel.org> References: <20190604013703.2043-1-dsahern@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 04 Jun 2019 14:55:22 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern Date: Mon, 3 Jun 2019 18:37:03 -0700 > From: David Ahern > > A recent commit had an unintended side effect with reject routes: > rt6i_pcpu is expected to always be initialized for all fib6_info except > the null entry. The commit mentioned below skips it for reject routes > and ends up leaking references to the loopback device. For example, > > ip netns add foo > ip -netns foo li set lo up > ip -netns foo -6 ro add blackhole 2001:db8:1::1 > ip netns exec foo ping6 2001:db8:1::1 > ip netns del foo > > ends up spewing: > unregister_netdevice: waiting for lo to become free. Usage count = 3 > > The fib_nh_common_init is not needed for reject routes (no ipv4 caching > or encaps), so move the alloc_percpu_gfp after it and adjust the goto label. > > Fixes: f40b6ae2b612 ("ipv6: Move pcpu cached routes to fib6_nh") > Signed-off-by: David Ahern Applied.