From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: brouer@redhat.com, <netdev@vger.kernel.org>, <kernel-team@fb.com>,
<bjorn.topel@intel.com>, <magnus.karlsson@intel.com>,
<ast@kernel.org>, <daniel@iogearbox.net>
Subject: Re: [PATCH v4 bpf-next 1/2] bpf: Allow bpf_map_lookup_elem() on an xskmap
Date: Tue, 4 Jun 2019 18:43:06 +0200 [thread overview]
Message-ID: <20190604184306.362d9d8e@carbon> (raw)
In-Reply-To: <20190603163852.2535150-2-jonathan.lemon@gmail.com>
On Mon, 3 Jun 2019 09:38:51 -0700
Jonathan Lemon <jonathan.lemon@gmail.com> wrote:
> Currently, the AF_XDP code uses a separate map in order to
> determine if an xsk is bound to a queue. Instead of doing this,
> have bpf_map_lookup_elem() return the queue_id, as a way of
> indicating that there is a valid entry at the map index.
Just a reminder, that once we choose a return value, there the
queue_id, then it basically becomes UAPI, and we cannot change it.
Can we somehow use BTF to allow us to extend this later?
I was also going to point out that, you cannot return a direct pointer
to queue_id, as BPF-prog side can modify this... but Daniel already
pointed this out.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-06-04 16:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 16:38 [PATCH v4 bpf-next 0/2] Better handling of xskmap entries Jonathan Lemon
2019-06-03 16:38 ` [PATCH v4 bpf-next 1/2] bpf: Allow bpf_map_lookup_elem() on an xskmap Jonathan Lemon
2019-06-04 14:54 ` Daniel Borkmann
2019-06-04 15:30 ` Daniel Borkmann
2019-06-04 16:43 ` Jesper Dangaard Brouer [this message]
2019-06-04 17:25 ` Jonathan Lemon
2019-06-04 18:12 ` Martin Lau
2019-06-05 8:45 ` Björn Töpel
2019-06-05 15:42 ` Jonathan Lemon
2019-06-04 18:18 ` Björn Töpel
2019-06-04 20:07 ` Toke Høiland-Jørgensen
2019-06-03 16:38 ` [PATCH v4 bpf-next 2/2] libbpf: remove qidconf and better support external bpf programs Jonathan Lemon
2019-06-04 6:06 ` [PATCH v4 bpf-next 0/2] Better handling of xskmap entries Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604184306.362d9d8e@carbon \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=daniel@iogearbox.net \
--cc=jonathan.lemon@gmail.com \
--cc=kernel-team@fb.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).